Skip to content

Refactor file transfer functionality #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maxceem opened this issue Feb 4, 2020 · 4 comments
Closed

Refactor file transfer functionality #461

maxceem opened this issue Feb 4, 2020 · 4 comments
Labels
hotfix Released
Milestone
2.0.0

Comments

@maxceem
Copy link
Contributor

maxceem commented Feb 4, 2020

  • use AWS SDK instead of AWS CLI via exec for transferring files between buckets
  • remove a redundant call for ${fileServiceUrl}uploadurl which we don't need anymore in Project Service

This refactoring shouldn't change any functionality and only improves internal code.
@maxceem maxceem added this to the 2.0.1 milestone Feb 4, 2020
@maxceem
Copy link
Contributor Author

maxceem commented Feb 4, 2020

How to test:

This was referenced Feb 5, 2020
Closed
Merged
@lakshmiathreya
Copy link

@nithyaasworld

@SathyaJayabal
Copy link

@maxceem , I was able to upload, edit and remove files from the assets library of a project in PROD.

@vikasrohit
Copy link

Closing the issue.

@vikasrohit vikasrohit modified the milestones: 2.1, 2.0.0 Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hotfix Released
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
4 participants
@maxceem @vikasrohit @lakshmiathreya @SathyaJayabal