Skip to content

Commit 871806c

Browse files
pin setup-envtest to go 1.20
Signed-off-by: Ryotaro Banno <[email protected]>
1 parent 03d3550 commit 871806c

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,4 +171,4 @@ $(CONTROLLER_GEN): $(LOCALBIN)
171171
.PHONY: envtest
172172
envtest: $(ENVTEST) ## Download envtest-setup locally if necessary.
173173
$(ENVTEST): $(LOCALBIN)
174-
test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
174+
test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@$(ENVTEST_VERSION)

versions.mk

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
CHART_TESTING_VERSION := 3.10.1
22
CONTROLLER_TOOLS_VERSION := v0.14.0
3+
# ENVTEST_VERSION is usually latest, but might need to be pinned from time to time.
4+
# Version pinning is needed due to version incompatibility between controller-runtime and setup-envtest.
5+
# For more information: https://github.com/kubernetes-sigs/controller-runtime/issues/2744
6+
ENVTEST_VERSION := bf15e44028f908c790721fc8fe67c7bf2d06a611
37
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
48
# NOTE: the suffix .x means wildcard match so specifying the latest patch version.
59
ENVTEST_K8S_VERSION := 1.29.x

0 commit comments

Comments
 (0)