wip more verbose for debugging

Author: bdarnell

appveyor.yml

@@ -84,7 +84,7 @@ test_script:
   # but for now it lets us avoid duplication with .travis.yml and tox.ini.
   # Running "py3x-full" would be nice but it's failing on installing
   # dependencies with no useful logs.
-  - "tox -e %TOX_ENV% -- %TOX_ARGS%"
+  - "tox -e %TOX_ENV% -- --verbose %TOX_ARGS%"
 
 after_test:
   # If tests are successful, create binary packages for the project.

tornado/platform/asyncio.py

@@ -515,7 +515,14 @@ def _run_select(
         # we can rely on so ensuring proper synchronization would be
         # tricky.
         try:
-            rs, ws, _ = select.select(to_read, to_write, [])
+            # On windows, selecting on a socket for write will not
+            # return the socket when there is an error (but selecting
+            # for reads works). Also select for errors when selecting
+            # for writes, and merge the results.
+            #
+            # https://github.com/python/cpython/blob/0dd98c2d00a75efbec19c2ed942923981bc06683/Lib/selectors.py#L313-L318
+            rs, ws, xs = select.select(to_read, to_write, to_write)
+            ws = ws + xs
         except OSError as e:
             # After remove_reader or remove_writer is called, the file
             # descriptor may subsequently be closed on the event loop
@@ -528,7 +535,7 @@ def _run_select(
             # event loop and we'll get the updated set of file
             # descriptors on the next iteration. Otherwise, raise the
             # original error.
-            if e.errno == getattr(errno, "WSAENOTOTSOCK", errno.EBADF):
+            if e.errno == getattr(errno, "WSAENOTSOCK", errno.EBADF):
                 rs, _, _ = select.select([self._waker_r.fileno()], [], [], 0)
                 if rs:
                     return rs, []

tornado/test/ioloop_test.py

@@ -400,9 +400,14 @@ def handle_read(fd, events):
             client.close()
             server.close()
 
+    @skipIfNonUnix
     @gen_test
     def test_init_close_race(self):
         # Regression test for #2367
+        #
+        # Skipped on windows because of what looks like a bug in the
+        # proactor event loop when started and stopped on non-main
+        # threads.
         def f():
             for i in range(10):
                 loop = IOLoop()

tornado/test/iostream_test.py

@@ -301,6 +301,7 @@ async def test_read_until_with_close_after_second_packet(self):
         async with self.iostream_pair() as (rs, ws):
             rf = asyncio.ensure_future(rs.read_until(b"done"))
             await ws.write(b"x" * 2048)
+            await asyncio.sleep(0.1)
             ws.write(b"done")
             ws.close()
             await rf