-
-
Notifications
You must be signed in to change notification settings - Fork 530
state desired/required tox plugins and warn/fail on missing ones #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This has been done via #936 |
after review of the pr i disagree, #936 doesnt even solve half of this |
It has the fail/warn part. Plugins can freely modify the envlist so nothing do there. What else am I missing? |
@gaborbernat all we have is fail - there is no warning mechanism, no running of working envs and i'm not sure if there is the plugin can add env`s to the envlist implemnted, so from my pov its not even half |
I don't think we should warn. If a dependency is missing a hard fail is the appropriate solution. While there's no plugin implemented I don't think there's any core changes needed for anyone to implement one. |
If no one does it in the meantime I'll implement one once #998 is done. |
#998 would make the considerations wrt warning and graceful degradation irrelevant as it could always be done correctly a initial api to have a canonical way to have plugins add plugin related env's might be nice to have as a followup - that way i would consider this one as done |
tox should have a way to specify desired/required tox plugins for use with a tox.ini
use case i have in mind:
tox-linting
plugin that handles checks for python 2/3 using flake8, rst-linter and/or other toolsThe text was updated successfully, but these errors were encountered: