Skip to content

state desired/required tox plugins and warn/fail on missing ones #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RonnyPfannschmidt opened this issue Nov 23, 2016 · 7 comments
Closed
Labels
area:configuration area:plugins-hooks needs:discussion It's not quite clear if and how this should be done

Comments

@RonnyPfannschmidt
Copy link

tox should have a way to specify desired/required tox plugins for use with a tox.ini

use case i have in mind:

  • create tox-linting plugin that handles checks for python 2/3 using flake8, rst-linter and/or other tools
  • let that plugin add its own envs to the envlist
  • make tox warn if its missing, potentially fail on CI if its not missing and unrelated environments are not selected
@obestwalter obestwalter added area:configuration area:plugins-hooks needs:discussion It's not quite clear if and how this should be done and removed enhancement labels Sep 4, 2017
@gaborbernat
Copy link
Member

This has been done via #936

@RonnyPfannschmidt
Copy link
Author

after review of the pr i disagree, #936 doesnt even solve half of this

@gaborbernat
Copy link
Member

It has the fail/warn part. Plugins can freely modify the envlist so nothing do there. What else am I missing?

@RonnyPfannschmidt
Copy link
Author

@gaborbernat all we have is fail - there is no warning mechanism, no running of working envs and i'm not sure if there is the plugin can add env`s to the envlist implemnted, so from my pov its not even half

@gaborbernat
Copy link
Member

I don't think we should warn. If a dependency is missing a hard fail is the appropriate solution. While there's no plugin implemented I don't think there's any core changes needed for anyone to implement one.

@gaborbernat
Copy link
Member

If no one does it in the meantime I'll implement one once #998 is done.

@RonnyPfannschmidt
Copy link
Author

#998 would make the considerations wrt warning and graceful degradation irrelevant as it could always be done correctly

a initial api to have a canonical way to have plugins add plugin related env's might be nice to have as a followup - that way i would consider this one as done

@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:configuration area:plugins-hooks needs:discussion It's not quite clear if and how this should be done
Projects
None yet
Development

No branches or pull requests

3 participants