-
Notifications
You must be signed in to change notification settings - Fork 4
refactor: NeoShowcase helm #1051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
motoki317
wants to merge
7
commits into
main
Choose a base branch
from
feat/ns-helm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+651
−1,824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27b8cac to
98e8d71
Compare
98e8d71 to
a215492
Compare
DiffNo diff detected! |
cdc31dd to
35a643e
Compare
c986e15 to
cd6da02
Compare
35a643e to
52e3196
Compare
52e3196 to
f6486e0
Compare
f6486e0 to
f20f030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NeoShowcaseをhelm化
詳しくは: traPtitech/NeoShowcase#1086
#1135 を先にmasterに入れる想定です。
必要な編集
ns-dev-systemのsecretに
kustomize.config.k8s.io/behavior: replaceとありますが、overlayでなくしたため必要なくなるので、以下のコマンドで削除してください。(直接編集するとmacが合わなくなってしまうため どうやら鍵を持っていないと編集できなかったようで...)