feat:自動でvalidationするCIを追加 #1203
Open
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiffNo diff detected! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Kentaro1043
requested changes
Oct 17, 2025
Comment on lines
6
to
7
| - "renovate-bot.js" | ||
| - "renovate/**" |
Collaborator
There was a problem hiding this comment.
パスが違う気がします
Suggested change
| - "renovate-bot.js" | |
| - "renovate/**" | |
| - ".github/renovate-bot.js" | |
| - ".github/renovate/**" |
| validate: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 |
Collaborator
There was a problem hiding this comment.
最新にするのが良いです
https://github.com/actions/checkout/releases
Suggested change
| - uses: actions/checkout@v4 | |
| - uses: actions/checkout@v5 |
Collaborator
|
Kentaro1043
requested changes
Dec 8, 2025
| - uses: actions/checkout@v5 | ||
|
|
||
| - name: Validate renovate-bot.js | ||
| if: ${{ exists('renovate-bot.js') }} |
Collaborator
There was a problem hiding this comment.
exists()という機能はないらしいです（GitHub Actions拡張機能を入れると解析してくれます）
${{ hashFiles('.github/renovate-bot.js') != '' }}みたいな感じにするといいかもです
Suggested change
| if: ${{ exists('renovate-bot.js') }} | |
| if: ${{ hashFiles('.github/renovate-bot.js') != '' }} |
Comment on lines
22
to
24
| - name: Validate renovate directory configs | ||
| run: | | ||
| find renovate -type f -name '*.json' -exec npx --yes renovate-config-validator {} \; No newline at end of file |
Collaborator
There was a problem hiding this comment.
findするディレクトリが違いそうです
find .github/renovateにするか、working-directoryで実行ディレクトリを指定できるのでどちらかをするといいです
Suggested change
| - name: Validate renovate directory configs | |
| run: | | |
| find renovate -type f -name '*.json' -exec npx --yes renovate-config-validator {} \; | |
| - name: Validate renovate directory configs | |
| working-directory: .github/renovate | |
| run: | | |
| find . -type f -name '*.json' -exec npx --yes renovate-config-validator {} \; |
y33550336
commented
Dec 8, 2025
| - name: Validate renovate-bot.js | ||
| if: ${{ hashFiles('.github/renovate-bot.js') != '' }} | ||
| run: | | ||
| npx --yes renovate-config-validator renovate-bot.js |
Contributor
Author
There was a problem hiding this comment.
とりあえず言われた二か所は直しました。AIに、
変更前:
npx --yes renovate-config-validator renovate-bot.js
変更後:
npx --yes renovate-config-validator .github/renovate-bot.js
にしたらと言われたのですがどうしますか
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
一応ちゃんと見ましたが、AIに任せた部分が多いので正しいか分からないです
#1109
質問
・.yamlの名前はvalidate-renovate-config.yamlでいいですか
・jobsの中のvalidateはcheckがいいですか(参考資料がcheckになっている)
・actions/checkout@v4よりもactions/checkout@v3の方がいいですか(参考資料がv3になっている)
・今は対象ファイルを二つのステップで分けていますが一つの方がいいですか