Skip to content

Conversation

@mehm8128
Copy link
Contributor

@mehm8128 mehm8128 commented Mar 9, 2023

close #8

@mehm8128 mehm8128 self-assigned this Mar 9, 2023
@mehm8128 mehm8128 force-pushed the feat/contest_new_page branch from 3bff0a9 to 35b2c4a Compare March 23, 2023 14:49
@mehm8128 mehm8128 marked this pull request as ready for review March 23, 2023 14:53
@mehm8128 mehm8128 requested review from tesso57 and toshi-pono March 23, 2023 14:53
Copy link
Member

@toshi-pono toshi-pono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いつも実装ありがとうございます:pray:
いくつか気づいたことをメモしましたので、参考になればと思います。

@mehm8128
Copy link
Contributor Author

mehm8128 commented Apr 15, 2023

バリデーションはteam editの方マージされたらそれ使ってやります
と思ったけど使うのvalidate.tsくらいなのでやりました

@mehm8128 mehm8128 requested a review from toshi-pono April 15, 2023 11:14
Copy link
Member

@toshi-pono toshi-pono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehm8128 mehm8128 merged commit 27bf3ad into main Apr 24, 2023
@mehm8128 mehm8128 deleted the feat/contest_new_page branch April 24, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/contest/new

3 participants