Skip to content

Conversation

@ikura-hamu
Copy link
Member

@ikura-hamu ikura-hamu commented Oct 12, 2025

PR Type

Enhancement, Configuration changes


Description

  • Dependabotグループのパターン指定を修正

  • 正規表現からワイルドカード形式へ変更

  • Go/SDK/Atlasの依存更新グループ安定化


Diagram Walkthrough

flowchart LR
  DEP["dependabot.yaml"] -- "regex -> wildcard" --> AWS["aws-sdk-go-v2/*"]
  DEP -- "regex -> wildcard" --> GOX["golang.org/x/*"]
  DEP -- "regex -> wildcard" --> GOLANG["golang*"]
  DEP -- "regex -> wildcard" --> ATLAS["arigaio/atlas*"]
Loading

File Walkthrough

Relevant files
Configuration changes
dependabot.yaml
Dependabotグルーピングのpatternをワイルドカード化                                               

.github/dependabot.yaml

  • aws-sdkのpatternを"*/"形式に変更
  • golang.org/xのpatternを"*/"形式に変更
  • golangイメージのpatternを"golang*"に変更
  • atlasのpatternを"arigaio/atlas*"に変更
+4/-4     

@ikura-hamu ikura-hamu requested a review from a team as a code owner October 12, 2025 22:51
@github-actions
Copy link

Migrate lint ✅

Lint output
Notice: Starting with v0.38, 'atlas migrate lint' will only be available in Atlas Pro.
The command and existing code remain open source and available in the Community Edition.
Learn more: https://atlasgo.io/blog-v037#deprecate-lint

@github-actions
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Pattern Specificity

ワイルドカードに変更したことでマッチ範囲が広がっています。意図せぬ依存がグルーピングされる可能性があるため、対象範囲が適切かを確認してください(例: "golang*" は docker タグや別イメージ名まで含む可能性)。

golang:
  patterns:
    - "golang*"
atlas:
  patterns:
    - "arigaio/atlas*"
Namespace Accuracy

"arigaio/atlas*" の指定が正しいオーガニゼーション/イメージ名かを再確認してください。もし "ariga/atlas" 等であればグループ化が効かない可能性があります。

atlas:
  patterns:
    - "arigaio/atlas*"
Ecosystem Matching

gomod のパターンはモジュールパス全体に対して評価されます。"github.com/aws/aws-sdk-go-v2/" と "golang.org/x/" が意図通り(サブモジュール含む)にマッチするか Dependabot のワイルドカード仕様に沿って再確認してください。

aws-sdk:
  patterns:
    - "github.com/aws/aws-sdk-go-v2/*"
  update-types:
    - minor
    - patch
golang.org:
  patterns:
    - "golang.org/x/*"

@github-actions
Copy link

github-actions bot commented Oct 12, 2025

Migrate lint ✅

Lint output
Notice: Starting with v0.38, 'atlas migrate lint' will only be available in Atlas Pro.
The command and existing code remain open source and available in the Community Edition.
Learn more: https://atlasgo.io/blog-v037#deprecate-lint

@codecov
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.16%. Comparing base (b06fe5e) to head (1024958).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1402   +/-   ##
=======================================
  Coverage   50.16%   50.16%           
=======================================
  Files         136      136           
  Lines       11874    11874           
=======================================
  Hits         5956     5956           
  Misses       5614     5614           
  Partials      304      304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ikura-hamu ikura-hamu requested a review from Copilot October 14, 2025 03:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Dependabot grouping patterns by converting regex patterns to wildcard format for more stable dependency update grouping.

  • Converts regex patterns (^prefix) to wildcard patterns (*suffix) for dependency groups
  • Updates AWS SDK, golang.org/x, golang, and Atlas dependency group patterns
  • Improves Dependabot configuration reliability by using simpler wildcard matching

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

golang:
patterns:
- "^golang"
- "golang"
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The golang pattern should use wildcard format 'golang*' to match the intended behavior described in the PR. Currently it will only match exact 'golang' packages, not golang-prefixed packages.

Suggested change
- "golang"
- "golang*"

Copilot uses AI. Check for mistakes.
@ikura-hamu ikura-hamu merged commit 3c70a32 into main Oct 14, 2025
12 checks passed
@ikura-hamu ikura-hamu deleted the ikura-hamu-patch-1 branch October 14, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants