Return reasons for build failures

Author: smoelius

backends/src/anchor/mod.rs

@@ -133,10 +133,9 @@ impl RunHigh for Anchor {
         context: &LightContext,
         test_name: &str,
         span: &Span,
-    ) -> Result<Option<(Exec, Option<Box<Postprocess>>)>> {
+    ) -> Result<Result<(Exec, Option<Box<Postprocess>>)>> {
         if let Err(error) = self.check(context, &span.source_file) {
-            debug!("{error}");
-            return Ok(None);
+            return Ok(Err(error));
         }
 
         let backup = self.patch_anchor_toml(&span.source_file, false)?;

backends/src/hardhat/mod.rs

@@ -78,10 +78,9 @@ impl RunHigh for Hardhat {
         context: &LightContext,
         test_name: &str,
         span: &Span,
-    ) -> Result<Option<(Exec, Option<Box<Postprocess>>)>> {
+    ) -> Result<Result<(Exec, Option<Box<Postprocess>>)>> {
         if let Err(error) = compile(context) {
-            debug!("{error}");
-            return Ok(None);
+            return Ok(Err(error));
         }
 
         let mut command = ts::utils::script("npx");

backends/src/lib.rs

@@ -140,7 +140,7 @@ impl<T: RunHigh> RunHigh for ParseAdapter<T> {
         context: &LightContext,
         test_name: &str,
         span: &Span,
-    ) -> Result<Option<(Exec, Option<Box<Postprocess>>)>> {
+    ) -> Result<Result<(Exec, Option<Box<Postprocess>>)>> {
         self.0.exec(context, test_name, span)
     }
 }

backends/src/running.rs

@@ -154,7 +154,7 @@ impl<T: RunLow> RunHigh for RunAdapter<T> {
         context: &LightContext,
         test_name: &str,
         span: &Span,
-    ) -> Result<Option<(Exec, Option<Box<Postprocess>>)>> {
+    ) -> Result<Result<(Exec, Option<Box<Postprocess>>)>> {
         {
             let mut command = self.0.command_to_build_test(context, test_name, span);
             command.args(&context.opts.args);
@@ -163,8 +163,7 @@ impl<T: RunLow> RunHigh for RunAdapter<T> {
 
             let output = command.output_stripped_of_ansi_escapes()?;
             if !output.status().success() {
-                debug!("{output}");
-                return Ok(None);
+                return Ok(Err(output.into()));
             }
         }
 
@@ -185,7 +184,7 @@ impl<T: RunLow> RunHigh for RunAdapter<T> {
         let test_name = test_name.to_owned();
         let span = span.clone();
 
-        Ok(Some((
+        Ok(Ok((
             exec,
             init_f_test.map(|(init, f)| -> Box<Postprocess> {
                 Box::new(move |context: &LightContext, mut popen| {

backends/src/ts/inner/mod.rs

@@ -131,7 +131,7 @@ impl Inner {
         test_name: &str,
         span: &Span,
         command: &Command,
-    ) -> Result<Option<(Exec, Option<Box<Postprocess>>)>> {
+    ) -> Result<Result<(Exec, Option<Box<Postprocess>>)>> {
         let mut source_file_it_message_state_map =
             self.source_file_it_message_state_map.borrow_mut();
         #[allow(clippy::expect_used)]
@@ -144,20 +144,21 @@ impl Inner {
             .entry(test_name.to_owned())
             .or_default();
         if *state != ItMessageState::Found {
+            let msg = format!("`it` message {test_name:?} was not found during dry run");
             if *state == ItMessageState::NotFound {
                 source_warn(
                     context,
                     Warning::ItMessageNotFound,
                     span,
-                    &format!("`it` message {test_name:?} was not found during dry run"),
+                    &msg,
                     WarnFlags::empty(),
                 )?;
                 *state = ItMessageState::WarningEmitted;
             }
-            // smoelius: Returning `None` here causes Necessist to associate `Outcome::Nonbuildable`
-            // with this span. This is not ideal, but there is no ideal choice for this situation
-            // currently.
-            return Ok(None);
+            // smoelius: Returning an error here causes Necessist to associate
+            // `Outcome::Nonbuildable` with this span. This is not ideal, but there is no ideal
+            // choice for this situation currently.
+            return Ok(Err(anyhow!(msg)));
         }
 
         let mut exec = util::exec_from_command(command);
@@ -166,7 +167,7 @@ impl Inner {
 
         debug!("{exec:?}");
 
-        Ok(Some((exec, None)))
+        Ok(Ok((exec, None)))
     }
 }
 

backends/src/ts/mocha.rs

@@ -69,7 +69,7 @@ impl MochaLike for Mocha {
         test_name: &str,
         span: &Span,
         command: &Command,
-    ) -> Result<Option<(Exec, Option<Box<Postprocess>>)>> {
+    ) -> Result<Result<(Exec, Option<Box<Postprocess>>)>> {
         self.0.exec(context, test_name, span, command)
     }
 }

backends/src/ts/mod.rs

@@ -36,7 +36,7 @@ pub trait MochaLike {
         test_name: &str,
         span: &Span,
         command: &Command,
-    ) -> Result<Option<(Exec, Option<Box<Postprocess>>)>>;
+    ) -> Result<Result<(Exec, Option<Box<Postprocess>>)>>;
 }
 
 impl ParseLow for Box<dyn MochaLike> {

backends/src/ts/vitest.rs

@@ -95,7 +95,7 @@ impl MochaLike for Vitest {
         test_name: &str,
         span: &Span,
         command: &Command,
-    ) -> Result<Option<(Exec, Option<Box<Postprocess>>)>> {
+    ) -> Result<Result<(Exec, Option<Box<Postprocess>>)>> {
         self.0.exec(context, test_name, span, command)
     }
 }

backends/src/vitest/mod.rs

@@ -84,7 +84,7 @@ impl RunHigh for Vitest {
         context: &LightContext,
         test_name: &str,
         span: &Span,
-    ) -> Result<Option<(Exec, Option<Box<Postprocess>>)>> {
+    ) -> Result<Result<(Exec, Option<Box<Postprocess>>)>> {
         let command = command_to_run_test(context, &span.source_file);
 
         self.mocha_adapter

core/src/core.rs

@@ -368,21 +368,25 @@ fn run(mut context: Context, source_file_span_test_map: SourceFileSpanTestMap) -
                             return Ok(outcome);
                         }
 
-                        if let Some((exec, postprocess)) =
-                            context.backend.exec(&context.light(), test_name, span)?
-                        {
-                            // smoelius: Even if the removal is explicit (i.e., not with
-                            // instrumentation), it doesn't hurt to set `NECESSIST_REMOVAL`.
-                            let exec = exec.env("NECESSIST_REMOVAL", span.id());
-
-                            perform_exec(&context, exec, postprocess)
-                        } else {
-                            assert!(
-                                explicit_removal,
-                                "Instrumentation failed to build after it was verified to"
-                            );
-
-                            Ok(Some(Outcome::Nonbuildable))
+                        let result = context.backend.exec(&context.light(), test_name, span)?;
+
+                        match result {
+                            Ok((exec, postprocess)) => {
+                                // smoelius: Even if the removal is explicit (i.e., not with
+                                // instrumentation), it doesn't hurt to set `NECESSIST_REMOVAL`.
+                                let exec = exec.env("NECESSIST_REMOVAL", span.id());
+
+                                perform_exec(&context, exec, postprocess)
+                            }
+                            Err(error) => {
+                                assert!(
+                                    explicit_removal,
+                                    "Instrumentation failed to build after it was verified to: \
+                                     {error}"
+                                );
+
+                                Ok(Some(Outcome::Nonbuildable))
+                            }
                         }
                     })?;