Skip to content

Commit 5ec5aa3

Browse files
authored
Bump pylint, resolve linter warnings and unify quotes (#38)
1 parent fcae917 commit 5ec5aa3

File tree

13 files changed

+845
-284
lines changed

13 files changed

+845
-284
lines changed

.github/workflows/main.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,11 @@ jobs:
2929
python -m pip install -U pip setuptools wheel
3030
python3 -m pip install -U .[dev]
3131
32+
- name: Check code formatting
33+
run: find singer tests -type f -name '*.py' | xargs unify --check-only
34+
3235
- name: Analysing the code with pylint
33-
run: |
34-
pylint singer --extension-pkg-whitelist=ciso8601 -d missing-docstring,broad-except,bare-except,too-many-return-statements,too-many-branches,too-many-arguments,no-else-return,too-few-public-methods,fixme,protected-access
36+
run: pylint singer
3537

3638
- name: Runs tests with coverage
3739
run: nosetests --with-doctest -v

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ install: check_prereqs
88
python3 -m pip install -e '.[dev]'
99

1010
pylinting:
11-
pylint singer --extension-pkg-whitelist=ciso8601 -d missing-docstring,broad-except,bare-except,too-many-return-statements,too-many-branches,too-many-arguments,no-else-return,too-few-public-methods,fixme,protected-access
11+
pylint singer
1212

1313
test:
1414
nosetests --with-doctest -v

0 commit comments

Comments
 (0)