fix(chips): Move trailing icon to isolated gridcell (#2097)

trimox · web-flow · commit 4f3ac9dee90b · 2020-02-15T19:58:18.000-05:00
closes #2096
diff --git a/packages/chips/chip-set.ts b/packages/chips/chip-set.ts
@@ -216,6 +216,7 @@ export class MdcChipSet extends MDCComponent<MDCChipSetFoundation>
 
     this._dropSubscriptions();
     this._chipRemovalSubscription?.unsubscribe();
+    this._foundation?.destroy();
   }
 
   // Implemented as part of ControlValueAccessor.
diff --git a/packages/chips/chip.ts b/packages/chips/chip.ts
@@ -101,7 +101,11 @@ export class MdcChipCheckmark {
       <mdc-chip-text *ngIf="label">{{label}}</mdc-chip-text>
       <ng-content></ng-content>
     </mdc-chip-primary-action>
-  </span>`,
+  </span>
+  <span role="gridcell" *ngIf="!!trailingIcon">
+    <ng-content select="mdc-chip-icon[trailing]"></ng-content>
+  </span>
+  `,
   encapsulation: ViewEncapsulation.None,
   changeDetection: ChangeDetectionStrategy.OnPush,
   providers: [MdcRipple]

Original file line number	Diff line number	Diff line change
`@@ -216,6 +216,7 @@ export class MdcChipSet extends MDCComponent<MDCChipSetFoundation>`
`216`	`216`
`217`	`217`	`this._dropSubscriptions();`
`218`	`218`	`this._chipRemovalSubscription?.unsubscribe();`
	`219`	`+ this._foundation?.destroy();`
`219`	`220`	`}`
`220`	`221`
`221`	`222`	`// Implemented as part of ControlValueAccessor.`