Merge pull request #1820 from troessner/fix-rubocop-offenses

Bump rubocop dependency versions and fix new offenses

Author: mvz

Gemfile

@@ -10,9 +10,9 @@ gem 'cucumber',              '~> 10.0'
 gem 'rake',                  '~> 13.0'
 gem 'rspec',                 '~> 3.0'
 gem 'rspec-benchmark',       '~> 0.6.0'
-gem 'rubocop',               '~> 1.76.1'
-gem 'rubocop-performance',   '~> 1.25.0'
-gem 'rubocop-rspec',         '~> 3.6.0'
+gem 'rubocop',               '~> 1.80.2'
+gem 'rubocop-performance',   '~> 1.26.0'
+gem 'rubocop-rspec',         '~> 3.7.0'
 gem 'simplecov',             '~> 0.22.0'
 gem 'yard',                  '~> 0.9.5'
 

docs/templates/default/docstring/setup.rb

@@ -17,8 +17,6 @@ def api_marker
   erb(:private) unless ['public', 'private'].include? api_text
 end
 
-private
-
 def api_text
   api_text = object.has_tag?(:api) && object.tag(:api).text
   api_text = 'public' if object.has_tag?(:public)

lib/reek/ast/node.rb

@@ -60,7 +60,7 @@ def name
       #
       # @example
       #   node.each_node(:send, [:mlhs]) do |call_node| .... end
-      #   node.each_node(:lvar).any? { |it| it.var_name == 'something' }
+      #   node.each_node(:lvar).any? { _1.var_name == 'something' }
       #   node.each_node([:block]).flat_map do |elem| ... end
       #
       # Returns an array with all matching nodes.

lib/reek/configuration/configuration_converter.rb

@@ -9,6 +9,7 @@ module Configuration
     class ConfigurationConverter
       REGEXABLE_ATTRIBUTES = %w(accept reject exclude).freeze
       include ConfigurationValidator
+
       attr_reader :configuration
 
       # @param configuration [Hash] e.g.

lib/reek/configuration/configuration_file_finder.rb

@@ -23,6 +23,7 @@ module ConfigurationFileFinder
 
       class << self
         include ConfigurationValidator
+
         #
         # Finds and loads a configuration file from a given path.
         #

lib/reek/context/code_context.rb

@@ -19,6 +19,7 @@ module Context
     class CodeContext
       include Enumerable
       extend Forwardable
+
       delegate [:name, :type] => :exp
 
       attr_reader :children, :parent, :exp, :statement_counter

lib/reek/smell_detectors/control_parameter_helpers/call_in_condition_finder.rb

@@ -75,7 +75,7 @@ def regular_call_involving_param?(call_node)
         # @return [Boolean] if the parameter is used in the given method call
         #
         def call_involving_param?(call_node)
-          call_node.each_node(:lvar).any? { |it| it.var_name == parameter }
+          call_node.each_node(:lvar).any? { _1.var_name == parameter }
         end
 
         #

lib/reek/smell_detectors/nested_iterators.rb

@@ -64,7 +64,7 @@ def sniff
       # @return [Array<Iterator>]
       #
       def find_violations
-        find_candidates.select { |it| it.depth > max_allowed_nesting }
+        find_candidates.select { _1.depth > max_allowed_nesting }
       end
 
       # Finds the set of independent most deeply nested iterators regardless of

lib/reek/smell_detectors/nil_check.rb

@@ -71,7 +71,7 @@ def comparison_call?(call)
         end
 
         def involves_nil?(call)
-          call.participants.any? { |it| it.type == :nil }
+          call.participants.any? { _1.type == :nil }
         end
 
         def comparison_methods
@@ -84,7 +84,7 @@ module NilWhenNodeDetector
         module_function
 
         def detect(node)
-          node.condition_list.any? { |it| it.type == :nil }
+          node.condition_list.any? { _1.type == :nil }
         end
       end
     end

lib/reek/smell_detectors/too_many_constants.rb

@@ -35,7 +35,7 @@ def self.default_config
       # @return [Array<SmellWarning>]
       #
       def sniff
-        count = context.local_nodes(:casgn).count { |it| !it.defines_module? }
+        count = context.local_nodes(:casgn).count { |node| !node.defines_module? }
 
         return [] if count <= max_allowed_constants