Replace Icons with Path of CDN, with Icons Base64 encoded

[HubGon]

Hey,
I recently found a tutorial of how to use custom icons for custom apps with TrueNAS. In this tutorial there is also a possibility to embed icons without any internet connection:
https://technotim.com/posts/truenas-docker-pro/#bonus-embed-icons-with-base64-no-internet-needed

I think this solution is also nice for the official supported apps of TrueNAS, so the System is more independent to an internet connection and your CDN is also less loaded.
What do you think?

Kind regards

[stavros-k]

Hello, there are few things that makes this hard to do.

For example,

• It makes it hard to verify in a PR that this data url is actually the icon and not something "invalid". Whether this is just a bad encoding that wont display something at all, or a NSFW icon or something that might be phishing etc. Yes the reviewer can go and validate it in a browser, but its a guaranteed that something will slip through the cracks.
• Screenshots are still fetched from the CDN, because those are much larger than an icon.
• You still need internet connection to fetch the catalog.

But, the browser already caches icons after first load.

That being said, you can open a feature request in https://forums.truenas.com/c/features/12, so that middleware caches the icons locally when the catalog is refreshed, and serve them from the NAS itself afterwards.