Skip to content

Commit 989e930

Browse files
author
Alex Wang
committed
Require enum34 only for Python versions before 3.4
enum34 appears to be a potential source of problems when installed in environments using Python 3.4 or later [0, 1]. Apparently enum34 1.1.8 was able to avoid these issues, but a regression was introduced in 1.1.9 and is still present in the most recent release [2]. This commit loosens the requirement on enum34 so that it is only installed if Python 3.3 or older is used. This particular solution requires setuptools v36.2 or newer [3]. If older versions of setuptools need to be supported, then the requirements can be put into an extras_require clause [4, 5]. [0]: python-poetry/poetry#1122 [1]: iterative/dvc#1995 [2]: https://web.archive.org/web/20200621215937/https://bitbucket.org/stoneleaf/enum34/issues/31/make-the-install-a-noop-on-python36 [3]: https://setuptools.readthedocs.io/en/latest/history.html#v36-2-0 [4]: robshakir/pyangbind#232 (comment) [5]: https://gitlab.com/pycqa/flake8/-/merge_requests/191/diffs
1 parent 5cc7236 commit 989e930

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

requirements-dev.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
applicationinsights >= 0.11.1
22
argparse >= 1.2.1
3-
enum34 >= 1.1.6
3+
enum34 >= 1.1.6 ; python_version < '3.4'
44
future >= 0.16.0
55
setuptools >= 36.0.1
66
wheel >= 0.29.0

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def get_timestamped_version(ver):
3838
'applicationinsights>=0.11.1',
3939
'future>=0.16.0',
4040
'wheel>=0.29.0',
41-
'enum34>=1.1.6'
41+
'enum34>=1.1.6;python_version<"3.4"'
4242
]
4343

4444
with open("README.md", "r") as fh:

0 commit comments

Comments
 (0)