Skip to content

Commit ccabbff

Browse files
nhuhuanaaupov
authored andcommitted
[BOLT] Remove --allow-stripped option
AllowStripped has not been used in BOLT. This option is replaced by actively detecting stripped binary. Test Plan: Reviewed By: Amir Differential Revision: https://reviews.llvm.org/D130036
1 parent 986362d commit ccabbff

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

bolt/lib/Rewrite/RewriteInstance.cpp

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -92,12 +92,6 @@ cl::opt<std::string>
9292
"output binary via bolt info section"),
9393
cl::cat(BoltCategory));
9494

95-
cl::opt<bool>
96-
AllowStripped("allow-stripped",
97-
cl::desc("allow processing of stripped binaries"),
98-
cl::Hidden,
99-
cl::cat(BoltCategory));
100-
10195
cl::opt<bool> DumpDotAll(
10296
"dump-dot-all",
10397
cl::desc("dump function CFGs to graphviz format after each stage;"
@@ -2813,13 +2807,11 @@ void RewriteInstance::preprocessProfileData() {
28132807
if (Error E = ProfileReader->preprocessProfile(*BC.get()))
28142808
report_error("cannot pre-process profile", std::move(E));
28152809

2816-
if (!BC->hasSymbolsWithFileName() && ProfileReader->hasLocalsWithFileName() &&
2817-
!opts::AllowStripped) {
2810+
if (!BC->hasSymbolsWithFileName() && ProfileReader->hasLocalsWithFileName()) {
28182811
errs() << "BOLT-ERROR: input binary does not have local file symbols "
28192812
"but profile data includes function names with embedded file "
28202813
"names. It appears that the input binary was stripped while a "
2821-
"profiled binary was not. If you know what you are doing and "
2822-
"wish to proceed, use -allow-stripped option.\n";
2814+
"profiled binary was not\n";
28232815
exit(1);
28242816
}
28252817
}

0 commit comments

Comments
 (0)