Skip to content

Commit 1999546

Browse files
author
Tijmen van der Burgt
committed
Add release instructions and bump version
1 parent 5a52319 commit 1999546

File tree

4 files changed

+136
-77
lines changed

4 files changed

+136
-77
lines changed

RELEASE.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
# Release procedure
2+
3+
1. Update `Subtle.Gui\Properties\AssemblyInfo.cs`
4+
2. **Subtle.Setup** > Properties (F4) > Update Version and generate a new ProductCode
5+
3. Build **Subtle.Setup** using `Release` configuration
6+
4. Run `release\release.cmd` and distribute `release\Subtle.exe`

Subtle.Gui/Properties/AssemblyInfo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,4 @@
3333
// by using the '*' as shown below:
3434
// [assembly: AssemblyVersion("1.0.*")]
3535
[assembly: AssemblyVersion("1.0.0.0")]
36-
[assembly: AssemblyFileVersion("0.4.1")]
36+
[assembly: AssemblyFileVersion("0.4.2")]

Subtle.Model/OSDbClient.cs

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -20,31 +20,31 @@ public class OSDbClient
2020
/// </summary>
2121
public const int SearchLimit = 100;
2222

23-
private readonly IOSDbProxy proxy;
24-
private Session session;
23+
private readonly IOSDbProxy _proxy;
24+
private Session _session;
2525

2626
public OSDbClient() : this(DefaultUserAgent)
2727
{
2828
}
2929

3030
public OSDbClient(string userAgent)
3131
{
32-
proxy = XmlRpcProxyGen.Create<IOSDbProxy>();
33-
proxy.Url = ApiUrl;
34-
proxy.UserAgent = userAgent;
35-
proxy.Timeout = (int)Timeout.TotalMilliseconds;
36-
proxy.EnableCompression = true;
32+
_proxy = XmlRpcProxyGen.Create<IOSDbProxy>();
33+
_proxy.Url = ApiUrl;
34+
_proxy.UserAgent = userAgent;
35+
_proxy.Timeout = (int)Timeout.TotalMilliseconds;
36+
_proxy.EnableCompression = true;
3737
}
3838

3939
public async Task<Session> InitSessionAsync()
4040
{
4141
var task = Task.Factory.FromAsync(
42-
(callback, state) => proxy.BeginLogIn(string.Empty, string.Empty, string.Empty, proxy.UserAgent, callback),
43-
proxy.EndLogIn,
42+
(callback, state) => _proxy.BeginLogIn(string.Empty, string.Empty, string.Empty, _proxy.UserAgent, callback),
43+
_proxy.EndLogIn,
4444
null);
4545

46-
session = await ExecuteOSDbTask(task);
47-
return session;
46+
_session = await ExecuteOSDbTask(task);
47+
return _session;
4848
}
4949

5050
public Task<SubtitleSearchResultCollection> SearchSubtitlesAsync(params SearchQuery[] query)
@@ -53,8 +53,8 @@ public Task<SubtitleSearchResultCollection> SearchSubtitlesAsync(params SearchQu
5353

5454
var options = new SearchOptions { Limit = SearchLimit };
5555
var task = Task.Factory.FromAsync(
56-
(callback, state) => proxy.BeginSearchSubtitles(session.Token, query, options, callback),
57-
proxy.EndSearchSubtitles,
56+
(callback, state) => _proxy.BeginSearchSubtitles(_session.Token, query, options, callback),
57+
_proxy.EndSearchSubtitles,
5858
null);
5959

6060
return ExecuteOSDbTask(task);
@@ -65,8 +65,8 @@ public Task<SubtitleFileCollection> DownloadSubtitlesAsync(params string[] fileI
6565
EnsureSession();
6666

6767
var task = Task.Factory.FromAsync(
68-
(callback, state) => proxy.BeginDownloadSubtitles(session.Token, fileIds, callback),
69-
proxy.EndDownloadSubtitles,
68+
(callback, state) => _proxy.BeginDownloadSubtitles(_session.Token, fileIds, callback),
69+
_proxy.EndDownloadSubtitles,
7070
null);
7171

7272
return ExecuteOSDbTask(task);
@@ -76,8 +76,8 @@ public async Task<ServerInfo> GetServerInfoAsync()
7676
{
7777
var watch = Stopwatch.StartNew();
7878
var task = Task.Factory.FromAsync(
79-
(callback, state) => proxy.BeginGetServerInfo(callback),
80-
proxy.EndGetServerInfo,
79+
(callback, state) => _proxy.BeginGetServerInfo(callback),
80+
_proxy.EndGetServerInfo,
8181
null);
8282

8383
var info = await task.WithTimeout(Timeout);
@@ -89,12 +89,12 @@ public async Task<ServerInfo> GetServerInfoAsync()
8989

9090
public LanguageCollection GetLanguages()
9191
{
92-
return proxy.GetLanguages();
92+
return _proxy.GetLanguages();
9393
}
9494

9595
private void EnsureSession()
9696
{
97-
if (string.IsNullOrEmpty(session?.Token))
97+
if (string.IsNullOrEmpty(_session?.Token))
9898
{
9999
throw new InvalidOperationException("Session is not initialized");
100100
}

0 commit comments

Comments
 (0)