Skip to content

Commit f355ca4

Browse files
authored
Merge pull request #415 from twisted/local-test
Add missing local test dep and document it
2 parents ccedc04 + 92a441a commit f355ca4

File tree

3 files changed

+23
-8
lines changed

3 files changed

+23
-8
lines changed

CONTRIBUTING.rst

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,27 @@ Running the test suite
8989
----------------------
9090

9191
We use the `twisted.trial`_ module and `tox`_ to run tests against all supported
92-
Python versions and operating systems. All test dependencies, other than tox, are installed
93-
automatically.
92+
Python versions and operating systems.
9493

9594
The following list contains some ways how to run the test suite:
9695

97-
* To run all tests, use::
96+
* To install this project into a virtualenv along with the dependencies necessary
97+
to run the tests and build the documentation::
98+
99+
$ pip install -e .[dev]
100+
101+
* To run the tests, use ``trial`` like so::
102+
103+
$ trial towncrier
104+
105+
* To investigate and debug errors, use the ``trial`` command like this::
106+
107+
$ trial -b towncrier
108+
109+
This will invoke a PDB session. If you press ``c`` it will continue running
110+
the test suite until it runs into an error.
111+
112+
* To run all tests against all supported versions, install tox and use::
98113

99114
$ tox
100115

@@ -120,12 +135,10 @@ The following list contains some ways how to run the test suite:
120135
$ pip install pre-commit
121136
$ pre-commit install
122137

123-
* To investigate and debug errors, use the ``trial`` command like this::
124-
125-
$ trial -b towncrier
126-
127-
This command creates a virtual environment and invokes a PDB session.
128138

139+
**Please note**: If the test suite works in tox, but doesn't by calling
140+
``trial``, it could be that you've got GPG-signing active for git commits which
141+
fails with our dummy test commits.
129142

130143
.. ### Links
131144

setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
"dev": [
5050
"packaging",
5151
"sphinx >= 5",
52+
"twisted",
5253
],
5354
},
5455
package_dir={"": "src"},
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Improved contribution documentation.

0 commit comments

Comments
 (0)