Skip to content

Commit dd5b98f

Browse files
scopmkurnikov
authored andcommitted
django.contrib.messages.api: use HttpRequest instead of WSGIRequest (#73)
Its error messages explicitly note that an HttpRequest is required. https://docs.djangoproject.com/en/2.1/_modules/django/contrib/messages/api/#add_message
1 parent e634a5d commit dd5b98f

File tree

1 file changed

+6
-7
lines changed
  • django-stubs/contrib/messages

1 file changed

+6
-7
lines changed

django-stubs/contrib/messages/api.pyi

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
from typing import Any, List, Optional, Union
22

33
from django.contrib.messages.storage.base import BaseStorage
4-
from django.core.handlers.wsgi import WSGIRequest
54
from django.http.request import HttpRequest
65

76
class MessageFailure(Exception): ...
87

98
def add_message(
10-
request: Optional[WSGIRequest],
9+
request: Optional[HttpRequest],
1110
level: int,
1211
message: str,
1312
extra_tags: str = ...,
@@ -16,12 +15,12 @@ def add_message(
1615
def get_messages(request: HttpRequest) -> Union[List[Any], BaseStorage]: ...
1716
def get_level(request: HttpRequest) -> int: ...
1817
def set_level(request: HttpRequest, level: int) -> bool: ...
19-
def debug(request: WSGIRequest, message: str, extra_tags: str = ..., fail_silently: Union[bool, str] = ...) -> None: ...
20-
def info(request: WSGIRequest, message: str, extra_tags: str = ..., fail_silently: Union[bool, str] = ...) -> None: ...
18+
def debug(request: HttpRequest, message: str, extra_tags: str = ..., fail_silently: Union[bool, str] = ...) -> None: ...
19+
def info(request: HttpRequest, message: str, extra_tags: str = ..., fail_silently: Union[bool, str] = ...) -> None: ...
2120
def success(
22-
request: WSGIRequest, message: str, extra_tags: str = ..., fail_silently: Union[bool, str] = ...
21+
request: HttpRequest, message: str, extra_tags: str = ..., fail_silently: Union[bool, str] = ...
2322
) -> None: ...
2423
def warning(
25-
request: WSGIRequest, message: str, extra_tags: str = ..., fail_silently: Union[bool, str] = ...
24+
request: HttpRequest, message: str, extra_tags: str = ..., fail_silently: Union[bool, str] = ...
2625
) -> None: ...
27-
def error(request: WSGIRequest, message: str, extra_tags: str = ..., fail_silently: Union[bool, str] = ...) -> None: ...
26+
def error(request: HttpRequest, message: str, extra_tags: str = ..., fail_silently: Union[bool, str] = ...) -> None: ...

0 commit comments

Comments
 (0)