Skip to content

Commit fff15a2

Browse files
committed
Correctly annotate with ChangeList in django.contrib.admin.filters
1 parent 7ca13c1 commit fff15a2

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

django-stubs/contrib/admin/filters.pyi

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ from collections.abc import Callable, Iterable, Iterator
22
from typing import Any
33

44
from django.contrib.admin.options import ModelAdmin
5+
from django.contrib.admin.views.main import ChangeList
56
from django.db.models.base import Model
67
from django.db.models.fields import Field
78
from django.db.models.fields.related import RelatedField
@@ -17,7 +18,7 @@ class ListFilter:
1718
self, request: HttpRequest, params: dict[str, str], model: type[Model], model_admin: ModelAdmin
1819
) -> None: ...
1920
def has_output(self) -> bool: ...
20-
def choices(self, changelist: Any) -> Iterator[dict[str, Any]]: ...
21+
def choices(self, changelist: ChangeList) -> Iterator[dict[str, Any]]: ...
2122
def queryset(self, request: HttpRequest, queryset: QuerySet) -> QuerySet | None: ...
2223
def expected_parameters(self) -> list[str | None]: ...
2324

@@ -26,7 +27,7 @@ class SimpleListFilter(ListFilter):
2627
lookup_choices: Any
2728
def value(self) -> str | None: ...
2829
def lookups(self, request: HttpRequest, model_admin: ModelAdmin) -> Iterable[tuple[Any, str]] | None: ...
29-
def choices(self, changelist: Any) -> Iterator[dict[str, Any]]: ...
30+
def choices(self, changelist: ChangeList) -> Iterator[dict[str, Any]]: ...
3031

3132
class FieldListFilter(ListFilter):
3233
field: Field
@@ -69,14 +70,14 @@ class RelatedFieldListFilter(FieldListFilter):
6970
def field_choices(
7071
self, field: RelatedField, request: HttpRequest, model_admin: ModelAdmin
7172
) -> list[tuple[str, str]]: ...
72-
def choices(self, changelist: Any) -> Iterator[dict[str, Any]]: ...
73+
def choices(self, changelist: ChangeList) -> Iterator[dict[str, Any]]: ...
7374

7475
class BooleanFieldListFilter(FieldListFilter):
7576
lookup_kwarg: str
7677
lookup_kwarg2: str
7778
lookup_val: Any
7879
lookup_val2: Any
79-
def choices(self, changelist: Any) -> Iterator[dict[str, Any]]: ...
80+
def choices(self, changelist: ChangeList) -> Iterator[dict[str, Any]]: ...
8081

8182
class ChoicesFieldListFilter(FieldListFilter):
8283
title: str
@@ -85,7 +86,7 @@ class ChoicesFieldListFilter(FieldListFilter):
8586
lookup_kwarg_isnull: str
8687
lookup_val: Any
8788
lookup_val_isnull: Any
88-
def choices(self, changelist: Any) -> Iterator[dict[str, Any]]: ...
89+
def choices(self, changelist: ChangeList) -> Iterator[dict[str, Any]]: ...
8990

9091
class DateFieldListFilter(FieldListFilter):
9192
field_generic: Any
@@ -94,7 +95,7 @@ class DateFieldListFilter(FieldListFilter):
9495
lookup_kwarg_until: Any
9596
links: Any
9697
lookup_kwarg_isnull: Any
97-
def choices(self, changelist: Any) -> Iterator[dict[str, Any]]: ...
98+
def choices(self, changelist: ChangeList) -> Iterator[dict[str, Any]]: ...
9899

99100
class AllValuesFieldListFilter(FieldListFilter):
100101
title: str
@@ -105,7 +106,7 @@ class AllValuesFieldListFilter(FieldListFilter):
105106
lookup_val_isnull: Any
106107
empty_value_display: str
107108
lookup_choices: QuerySet
108-
def choices(self, changelist: Any) -> Iterator[dict[str, Any]]: ...
109+
def choices(self, changelist: ChangeList) -> Iterator[dict[str, Any]]: ...
109110

110111
class RelatedOnlyFieldListFilter(RelatedFieldListFilter):
111112
lookup_kwarg: str
@@ -118,4 +119,4 @@ class RelatedOnlyFieldListFilter(RelatedFieldListFilter):
118119
class EmptyFieldListFilter(FieldListFilter):
119120
lookup_kwarg: str
120121
lookup_val: Any
121-
def choices(self, changelist: Any) -> Iterator[dict[str, Any]]: ...
122+
def choices(self, changelist: ChangeList) -> Iterator[dict[str, Any]]: ...

0 commit comments

Comments
 (0)