Add typing for data parameter in get from RequestFactory, test Client and urlencode #1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intgr
changed the title
intgr
reviewed
Dec 21, 2022
intgr
approved these changes
Jan 4, 2023
Collaborator
intgr
left a comment
intgr
left a comment
There was a problem hiding this comment.
I added the from typing_extensions import TypeAlias myself and this now passes tests.
In the related djangorestframework-stubs PR (typeddjango/djangorestframework-stubs#267 (comment)) we had the dilemma about allowing int. I don't feel strongly about that, it can be added later if someone finds it useful.
Collaborator
|
Thanks! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and urlencode
Following on typeddjango/djangorestframework-stubs#267 by adding the same typing information to the corresponding django stubs.
The data parameter in both
getmethods is fed tourlencode, and that function takes either a mapping or a list of tuples of URL parameters.