Allow subclasses of APIView to override get_permissions with return type implementing _SupportsHasPermission #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The |
intgr
added a commit
that referenced
this pull request
Jan 19, 2023
Suppressing new typecheck errors that were exposed in #320. Now ignoring messages like 'note: "SimpleRouter" defined here' and "note: 'IntegerSerializer" defined here' globally because these aren't actually errors, just context.
Contributor
|
I rebased this branch on top of CI fixes and tests pass now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #319
Issue is that
listis invariant, which makes the protocol not work.Changing it so a sequence of course breaks stuff that relies on the result being mutable, but I am assuming that that should not be supported anyways.