Skip to content

Upgrade to Mypy 1.0 #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 21, 2023
Merged

Upgrade to Mypy 1.0 #339

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
36c5e8a
Upgrade to Mypy 1.0
christianbundy Feb 6, 2023
5f7b015
Merge branch 'master' of github.com:typeddjango/djangorestframework-s…
christianbundy Feb 18, 2023
257c2ba
Fix tests
christianbundy Feb 18, 2023
ddb97a7
Appease pre-commit
christianbundy Feb 20, 2023
0dac7f6
Re-add ignores from other Python versions
christianbundy Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions scripts/typecheck_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,9 @@
"test_permissions.py": [
'"ResolverMatch" has incompatible type "str"; expected "Callable[..., Any]"',
"_SupportsHasPermission",
"Invalid type alias: expression is not a valid type",
'"object" not callable',
'Cannot assign multiple types to name "composed_perm" without an explicit "Type[...]" annotation',
'"<typing special form>" not callable',
'<nothing> not callable',
],
"test_relations.py": [
'Invalid index type "int" for "Union[str, _StrPromise, List[Any], Dict[str, Any]]"; expected type "str"',
Expand Down Expand Up @@ -188,8 +188,6 @@
"base class",
'"CharField" has incompatible type "Collection[Any]"',
'Name "foo" is not defined',
'Unsupported left operand type for | ("ReturnDict")',
'Unsupported left operand type for | ("Dict[str, str]")',
],
"test_serializer_lists.py": [
'Name "foo" is not defined',
Expand All @@ -208,7 +206,6 @@
"test_testing.py": [
'"Client" has no attribute "force_authenticate"',
'"Client" has no attribute "credentials"',
'has no attribute "addClassCleanup"',
],
"test_throttling.py": [
'has incompatible type "Dict[<nothing>, <nothing>]"',
Expand Down Expand Up @@ -237,6 +234,7 @@
"rest_framework.decorators",
'Argument 1 to "include" has incompatible type "Tuple[List[object], str]"',
'Incompatible types in assignment (expression has type "Type[FakeResolverMatch]", variable has type "Optional[ResolverMatch]"', # noqa: E501
'"None" not callable'
],
"test_viewsets.py": [
'(expression has type "None", variable has type "Request")',
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def find_stub_files(name):
]

extras_require = {
"compatible-mypy": ["mypy>=0.991,<0.1000"],
"compatible-mypy": ["mypy>=1.0,<1.1"],
"coreapi": ["coreapi>=2.0.0"],
"markdown": ["types-Markdown>=0.1.5"],
}
Expand Down