chore: expand eslint-plugin rules test files glob (#12878)

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: 3 people

eslint.config.mjs

@@ -706,7 +706,10 @@ export default defineConfig(
   },
   {
     name: 'eslint-plugin-rules-test-files',
-    files: ['packages/eslint-plugin/tests/rules/*.test.ts'],
+    files: [
+      'packages/eslint-plugin-internal/tests/rules/**/*.test.ts',
+      'packages/eslint-plugin/tests/{eslint-rules,rules}/**/*.test.ts',
+    ],
     rules: {
       'perfectionist/sort-objects': [
         'error',

packages/eslint-plugin-internal/tests/rules/debug-namespace.test.ts

@@ -8,6 +8,32 @@ ruleTester.run('debug-namespace', rule, {
   assertionOptions: {
     requireData: true,
   },
+  valid: [
+    {
+      code: "const log = debug('typescript-eslint:example:file');",
+      filename: 'typescript-eslint/packages/example/file.ts',
+    },
+    {
+      code: "const logCustom = debug('typescript-eslint:example:file');",
+      filename: 'typescript-eslint/packages/example/file.ts',
+    },
+    {
+      code: "const logCustom = debug('...');",
+      filename: 'typescript-eslint/packages/example/file.ts',
+    },
+    {
+      code: "debug('...');",
+      filename: 'typescript-eslint/packages/example/file.ts',
+    },
+    {
+      code: 'const log = debug(null);',
+      filename: 'typescript-eslint/packages/example/file.ts',
+    },
+    {
+      code: 'const log = debug(123);',
+      filename: 'typescript-eslint/packages/example/file.ts',
+    },
+  ],
   invalid: [
     {
       code: "const log = debug('not:correct');",
@@ -52,30 +78,4 @@ ruleTester.run('debug-namespace', rule, {
       output: "const log = debug('typescript-eslint:example:file');",
     },
   ],
-  valid: [
-    {
-      code: "const log = debug('typescript-eslint:example:file');",
-      filename: 'typescript-eslint/packages/example/file.ts',
-    },
-    {
-      code: "const logCustom = debug('typescript-eslint:example:file');",
-      filename: 'typescript-eslint/packages/example/file.ts',
-    },
-    {
-      code: "const logCustom = debug('...');",
-      filename: 'typescript-eslint/packages/example/file.ts',
-    },
-    {
-      code: "debug('...');",
-      filename: 'typescript-eslint/packages/example/file.ts',
-    },
-    {
-      code: 'const log = debug(null);',
-      filename: 'typescript-eslint/packages/example/file.ts',
-    },
-    {
-      code: 'const log = debug(123);',
-      filename: 'typescript-eslint/packages/example/file.ts',
-    },
-  ],
 });

packages/eslint-plugin-internal/tests/rules/eqeq-nullish.test.ts

@@ -8,6 +8,16 @@ ruleTester.run('eqeq-nullish', rule, {
   assertionOptions: {
     requireData: true,
   },
+  valid: [
+    'null == a;',
+    'foo != null;',
+    'foo === bar;',
+    'foo !== bar;',
+    // We're not trying to duplicate eqeqeq's reports.
+    'a == b;',
+    'something == undefined;',
+    'undefined != something;',
+  ],
   invalid: [
     {
       code: 'something === undefined;',
@@ -85,14 +95,4 @@ ruleTester.run('eqeq-nullish', rule, {
       ],
     },
   ],
-  valid: [
-    'null == a;',
-    'foo != null;',
-    'foo === bar;',
-    'foo !== bar;',
-    // We're not trying to duplicate eqeqeq's reports.
-    'a == b;',
-    'something == undefined;',
-    'undefined != something;',
-  ],
 });

packages/eslint-plugin-internal/tests/rules/no-dynamic-tests.test.ts

@@ -16,6 +16,82 @@ ruleTester.run('no-dynamic-tests', rule, {
   assertionOptions: {
     requireData: true,
   },
+  valid: [
+    {
+      code: `
+ruleTester.run('test', rule, {
+  valid: ['const x = 1;'],
+  invalid: [],
+});
+      `,
+    },
+    {
+      code: `
+ruleTester.run('test', rule, {
+  valid: ['const x = 1;', 'let y = 2;'],
+  invalid: [
+    {
+      code: 'var z = 3;',
+      errors: [{ messageId: 'error' }],
+    },
+  ],
+});
+      `,
+    },
+    {
+      code: `
+ruleTester.run('test', rule, {
+  valid: [{ code: 'const x = 1;' }, { code: 'let y = 2;' }],
+  invalid: [],
+});
+      `,
+    },
+    {
+      code: `
+ruleTester.run('test', rule, {
+  valid: [noFormat\`const x = 1;\`],
+  invalid: [],
+});
+      `,
+    },
+    {
+      code: `
+ruleTester.run('test', rule, {
+  valid: [{ code: noFormat\`const x = 1;\` }],
+  invalid: [],
+});
+      `,
+    },
+    {
+      code: `
+ruleTester.run('test', rule, {
+  code: "import type { ValueOf } from './utils';",
+  filename: path.resolve(
+    PACKAGES_DIR,
+    'ast-spec/src/expression/AssignmentExpression/spec.ts',
+  ),
+});
+      `,
+    },
+    `
+ruleTester.run('test', rule, {
+  valid: [],
+  invalid: [
+    {
+      code: 'x.y!;',
+      errors: [
+        {
+          column: 1,
+          line: 1,
+          messageId: 'noNonNull',
+          suggestions: undefined,
+        },
+      ],
+    },
+  ],
+});
+    `,
+  ],
   invalid: [
     // Function calls in test arrays
     {
@@ -356,80 +432,4 @@ ruleTester.run('test', rule, {
       `,
     },
   ],
-  valid: [
-    {
-      code: `
-ruleTester.run('test', rule, {
-  valid: ['const x = 1;'],
-  invalid: [],
-});
-      `,
-    },
-    {
-      code: `
-ruleTester.run('test', rule, {
-  valid: ['const x = 1;', 'let y = 2;'],
-  invalid: [
-    {
-      code: 'var z = 3;',
-      errors: [{ messageId: 'error' }],
-    },
-  ],
-});
-      `,
-    },
-    {
-      code: `
-ruleTester.run('test', rule, {
-  valid: [{ code: 'const x = 1;' }, { code: 'let y = 2;' }],
-  invalid: [],
-});
-      `,
-    },
-    {
-      code: `
-ruleTester.run('test', rule, {
-  valid: [noFormat\`const x = 1;\`],
-  invalid: [],
-});
-      `,
-    },
-    {
-      code: `
-ruleTester.run('test', rule, {
-  valid: [{ code: noFormat\`const x = 1;\` }],
-  invalid: [],
-});
-      `,
-    },
-    {
-      code: `
-ruleTester.run('test', rule, {
-  code: "import type { ValueOf } from './utils';",
-  filename: path.resolve(
-    PACKAGES_DIR,
-    'ast-spec/src/expression/AssignmentExpression/spec.ts',
-  ),
-});
-      `,
-    },
-    `
-ruleTester.run('test', rule, {
-  valid: [],
-  invalid: [
-    {
-      code: 'x.y!;',
-      errors: [
-        {
-          column: 1,
-          line: 1,
-          messageId: 'noNonNull',
-          suggestions: undefined,
-        },
-      ],
-    },
-  ],
-});
-    `,
-  ],
 });