V14 QA Fixed the failing smoke tests (#16953)

* Updated api tests for Data type due to test helper changes

* Fixed Data Type tests due to test helper changes

* Updated the test for edit password due to ui helper changes

* Bumped version

Author: nhudinh0309

tests/Umbraco.Tests.AcceptanceTest/package-lock.json

@@ -22,7 +22,7 @@
   },
   "dependencies": {
     "@umbraco/json-models-builders": "^2.0.17",
-    "@umbraco/playwright-testhelpers": "^2.0.0-beta.76",
+    "@umbraco/playwright-testhelpers": "^2.0.0-beta.77",
     "camelize": "^1.0.0",
     "dotenv": "^16.3.1",
     "faker": "^4.1.0",

tests/Umbraco.Tests.AcceptanceTest/package.json

@@ -9,6 +9,7 @@ test.describe('DataType tests', () => {
   const dataTypeName = 'TestDataType';
   const folderName = 'TestDataTypeFolder';
   const editorAlias = 'Umbraco.DateTime';
+  const editorUiAlias = 'Umb.PropertyEditorUi.DatePicker';
   const dataTypeData = [
     {
       "alias": "tester",
@@ -29,15 +30,15 @@ test.describe('DataType tests', () => {
 
   test('can create dataType', async ({umbracoApi}) => {
     // Act
-    dataTypeId = await umbracoApi.dataType.create(dataTypeName, editorAlias, dataTypeData);
+    dataTypeId = await umbracoApi.dataType.create(dataTypeName, editorAlias, editorUiAlias, dataTypeData);
 
     // Assert
     expect(umbracoApi.dataType.doesExist(dataTypeId)).toBeTruthy();
   });
 
   test('can update dataType', async ({umbracoApi}) => {
     // Arrange
-    dataTypeId = await umbracoApi.dataType.create(dataTypeName, editorAlias, []);
+    dataTypeId = await umbracoApi.dataType.create(dataTypeName, editorAlias, editorUiAlias, []);
     const dataType = await umbracoApi.dataType.get(dataTypeId);
     dataType.values = dataTypeData;
 
@@ -52,7 +53,7 @@ test.describe('DataType tests', () => {
 
   test('can delete dataType', async ({umbracoApi}) => {
     // Arrange
-    dataTypeId = await umbracoApi.dataType.create(dataTypeName, editorAlias, dataTypeData);
+    dataTypeId = await umbracoApi.dataType.create(dataTypeName, editorAlias, editorUiAlias, dataTypeData);
     expect(await umbracoApi.dataType.doesExist(dataTypeId)).toBeTruthy();
 
     // Act
@@ -65,7 +66,7 @@ test.describe('DataType tests', () => {
   test('can move a dataType to a folder', async ({umbracoApi}) => {
     // Arrange
     await umbracoApi.dataType.ensureNameNotExists(folderName);
-    dataTypeId = await umbracoApi.dataType.create(dataTypeName, editorAlias, dataTypeData);
+    dataTypeId = await umbracoApi.dataType.create(dataTypeName, editorAlias, editorUiAlias, dataTypeData);
     expect(await umbracoApi.dataType.doesNameExist(dataTypeName)).toBeTruthy();
     dataTypeFolderId = await umbracoApi.dataType.createFolder(folderName);
     expect(await umbracoApi.dataType.doesFolderExist(dataTypeFolderId)).toBeTruthy();
@@ -82,7 +83,7 @@ test.describe('DataType tests', () => {
   test('can copy a dataType to a folder', async ({umbracoApi}) => {
     // Arrange
     await umbracoApi.dataType.ensureNameNotExists(folderName);
-    dataTypeId = await umbracoApi.dataType.create(dataTypeName, editorAlias, dataTypeData);
+    dataTypeId = await umbracoApi.dataType.create(dataTypeName, editorAlias, editorUiAlias, dataTypeData);
     dataTypeFolderId = await umbracoApi.dataType.createFolder(folderName);
 
     const dataType = await umbracoApi.dataType.get(dataTypeId);

tests/Umbraco.Tests.AcceptanceTest/tests/ApiTesting/DataType/DataType.spec.ts

@@ -2,8 +2,6 @@
 import {expect} from "@playwright/test";
 
 const dataTypeName = 'TestDataType';
-const editorAlias = 'Umbraco.ColorPicker';
-const propertyEditorName = 'Color Picker';
 
 test.beforeEach(async ({umbracoApi, umbracoUi}) => {
   await umbracoApi.dataType.ensureNameNotExists(dataTypeName);
@@ -22,7 +20,7 @@ test('can create a data type', {tag: '@smoke'}, async ({umbracoApi, umbracoUi})
   await umbracoUi.dataType.clickNewDataTypeThreeDotsButton();
   await umbracoUi.dataType.enterDataTypeName(dataTypeName);
   await umbracoUi.dataType.clickSelectAPropertyEditorButton();
-  await umbracoUi.dataType.selectAPropertyEditor(propertyEditorName);
+  await umbracoUi.dataType.selectAPropertyEditor('Text Box');
   await umbracoUi.dataType.clickSaveButton();
 
   // Assert
@@ -34,7 +32,7 @@ test('can rename a data type', {tag: '@smoke'}, async ({umbracoApi, umbracoUi})
   // Arrange
   const wrongDataTypeName = 'Wrong Data Type';
   await umbracoApi.dataType.ensureNameNotExists(wrongDataTypeName);
-  await umbracoApi.dataType.create(wrongDataTypeName, editorAlias, []);
+  await umbracoApi.dataType.createTextstringDataType(wrongDataTypeName);
   expect(await umbracoApi.dataType.doesNameExist(wrongDataTypeName)).toBeTruthy();
 
   // Act
@@ -49,7 +47,7 @@ test('can rename a data type', {tag: '@smoke'}, async ({umbracoApi, umbracoUi})
 
 test('can delete a data type', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => {
   // Arrange
-  await umbracoApi.dataType.create(dataTypeName, editorAlias, []);
+  await umbracoApi.dataType.createTextstringDataType(dataTypeName);
   expect(await umbracoApi.dataType.doesNameExist(dataTypeName)).toBeTruthy();
 
   // Act
@@ -67,7 +65,7 @@ test('can change property editor in a data type', {tag: '@smoke'}, async ({umbra
   const updatedEditorAlias = 'Umbraco.TextArea';
   const updatedEditorUiAlias = 'Umb.PropertyEditorUi.TextArea';
 
-  await umbracoApi.dataType.create(dataTypeName, editorAlias, []);
+  await umbracoApi.dataType.createTextstringDataType(dataTypeName);
   expect(await umbracoApi.dataType.doesNameExist(dataTypeName)).toBeTruthy();
 
   // Act
@@ -98,16 +96,17 @@ test('cannot create a data type without selecting the property editor', {tag: '@
 
 test('can change settings', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => {
   // Arrange
+  const maxCharsValue = 126;
   const expectedDataTypeValues = {
-    alias: "useLabel",
-    value: true
+    "alias": "maxChars",
+    "value": maxCharsValue
   };
-  await umbracoApi.dataType.create(dataTypeName, editorAlias, []);
+  await umbracoApi.dataType.createTextstringDataType(dataTypeName);
   expect(await umbracoApi.dataType.doesNameExist(dataTypeName)).toBeTruthy();
 
   // Act
   await umbracoUi.dataType.goToDataType(dataTypeName);
-  await umbracoUi.dataType.clickIncludeLabelsSlider();
+  await umbracoUi.dataType.enterMaximumAllowedCharactersValue(maxCharsValue.toString());
   await umbracoUi.dataType.clickSaveButton();
 
   // Assert

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DataType.spec.ts

@@ -106,7 +106,7 @@ test('can edit password', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => {
   // Act
   await umbracoUi.member.clickMemberLinkByName(memberName);
   await umbracoUi.member.clickChangePasswordButton();
-  await umbracoUi.member.enterPassword(updatedPassword);
+  await umbracoUi.member.enterNewPassword(updatedPassword);
   await umbracoUi.member.enterConfirmNewPassword(updatedPassword);
   await umbracoUi.member.clickSaveButton();