fix(core,tools): Fix TypeScript compilation errors

- Export ToolScopeItemResponseModel and ToolItemResponseModel types
- Remove unused imports (nothing, state)
- Fix UserGroupService import (was type, needs to be value)
- Fix modal manager null checks
- Fix modal result handling with onSubmit()
- Remove non-existent description property access

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: mattbrailsford

Umbraco.AI/src/Umbraco.AI.Web.StaticAssets/Client/src/core/components/user-group-settings-list/user-group-settings-list.element.ts

@@ -2,7 +2,6 @@ import {
 	css,
 	customElement,
 	html,
-	nothing,
 	property,
 	repeat,
 	state,
@@ -14,7 +13,7 @@ import { UmbChangeEvent } from "@umbraco-cms/backoffice/event";
 import type { UmbModalToken } from "@umbraco-cms/backoffice/modal";
 import { UMB_MODAL_MANAGER_CONTEXT } from "@umbraco-cms/backoffice/modal";
 import { UMB_USER_GROUP_PICKER_MODAL } from "@umbraco-cms/backoffice/user-group";
-import type { UserGroupService } from "@umbraco-cms/backoffice/external/backend-api";
+import { UserGroupService } from "@umbraco-cms/backoffice/external/backend-api";
 import { tryExecuteAndNotify } from "@umbraco-cms/backoffice/resources";
 
 /**
@@ -186,6 +185,7 @@ export class UaiUserGroupSettingsListElement<TSettings> extends UmbLitElement {
 	 */
 	private async _addUserGroup(): Promise<void> {
 		const modalManager = await this.getContext(UMB_MODAL_MANAGER_CONTEXT);
+		if (!modalManager) return;
 
 		// 1. Open user group picker
 		const pickerResult = await modalManager.open(this, UMB_USER_GROUP_PICKER_MODAL, {
@@ -194,11 +194,12 @@ export class UaiUserGroupSettingsListElement<TSettings> extends UmbLitElement {
 			},
 		});
 
-		if (!pickerResult || !pickerResult.selection || pickerResult.selection.length === 0) {
+		const pickerValue = await pickerResult?.onSubmit();
+		if (!pickerValue || !pickerValue.selection || pickerValue.selection.length === 0) {
 			return;
 		}
 
-		const userGroupId = pickerResult.selection[0];
+		const userGroupId = pickerValue.selection[0];
 
 		// Check if already configured
 		if (this.value[userGroupId]) {
@@ -211,10 +212,11 @@ export class UaiUserGroupSettingsListElement<TSettings> extends UmbLitElement {
 
 		// 3. Open editor modal
 		const modalData = this.config.editorModal.createData(userGroupId, userGroupName);
-		const modalResult = await modalManager.open(this, this.config.editorModal.token, {
+		const modal = modalManager.open(this, this.config.editorModal.token, {
 			data: modalData,
 		});
 
+		const modalResult = await modal.onSubmit();
 		if (!modalResult) {
 			return;
 		}
@@ -230,14 +232,17 @@ export class UaiUserGroupSettingsListElement<TSettings> extends UmbLitElement {
 	 */
 	private async _editUserGroup(userGroupId: string): Promise<void> {
 		const modalManager = await this.getContext(UMB_MODAL_MANAGER_CONTEXT);
+		if (!modalManager) return;
+
 		const userGroupName = (await this._getUserGroupName(userGroupId)) ?? userGroupId;
 		const existingSettings = this.value[userGroupId];
 
 		const modalData = this.config.editorModal.createData(userGroupId, userGroupName, existingSettings);
-		const modalResult = await modalManager.open(this, this.config.editorModal.token, {
+		const modal = modalManager.open(this, this.config.editorModal.token, {
 			data: modalData,
 		});
 
+		const modalResult = await modal.onSubmit();
 		if (!modalResult) {
 			return;
 		}

Umbraco.AI/src/Umbraco.AI.Web.StaticAssets/Client/src/tool/components/tool-permissions-override/tool-permissions-override.element.ts

@@ -2,7 +2,6 @@ import {
 	css,
 	customElement,
 	html,
-	nothing,
 	property,
 	repeat,
 	state,

Umbraco.AI/src/Umbraco.AI.Web.StaticAssets/Client/src/tool/components/tool-scope-permissions-override/tool-scope-permissions-override.element.ts

@@ -2,10 +2,8 @@ import {
 	css,
 	customElement,
 	html,
-	nothing,
 	property,
 	repeat,
-	state,
 	when,
 } from "@umbraco-cms/backoffice/external/lit";
 import { UmbLitElement } from "@umbraco-cms/backoffice/lit-element";
@@ -149,7 +147,7 @@ export class UaiToolScopePermissionsOverrideElement extends UmbLitElement {
 				const camelCaseId = toCamelCase(scope.id);
 				const localizedName = this.localize.term(`uaiToolScope_${camelCaseId}Label`) || scope.id;
 				const localizedDescription =
-					this.localize.term(`uaiToolScope_${camelCaseId}Description`) || scope.description || "";
+					this.localize.term(`uaiToolScope_${camelCaseId}Description`) || "";
 
 				return {
 					value: scope.id,

Umbraco.AI/src/Umbraco.AI.Web.StaticAssets/Client/src/tool/components/tool-scope-picker/tool-scope-picker.element.ts

@@ -108,7 +108,7 @@ export class UaiToolScopePickerElement extends UmbFormControlMixin<string[] | un
                     const camelCaseId = toCamelCase(scope.id);
                     const localizedName = this.localize.term(`uaiToolScope_${camelCaseId}Label`) || scope.id;
                     const localizedDescription =
-                        this.localize.term(`uaiToolScope_${camelCaseId}Description`) || scope.description || "";
+                        this.localize.term(`uaiToolScope_${camelCaseId}Description`) || "";
 
                     return {
                         id: scope.id,
@@ -161,7 +161,7 @@ export class UaiToolScopePickerElement extends UmbFormControlMixin<string[] | un
                 const camelCaseId = toCamelCase(scope.id);
                 const localizedName = this.localize.term(`uaiToolScope_${camelCaseId}Label`) || scope.id;
                 const localizedDescription =
-                    this.localize.term(`uaiToolScope_${camelCaseId}Description`) || scope.description || "";
+                    this.localize.term(`uaiToolScope_${camelCaseId}Description`) || "";
 
                 return {
                     value: scope.id,

Umbraco.AI/src/Umbraco.AI.Web.StaticAssets/Client/src/tool/repository/tool.repository.ts

@@ -3,6 +3,9 @@ import type { UmbControllerHost } from "@umbraco-cms/backoffice/controller-api";
 import { UaiToolServerDataSource } from "./tool.server.data-source.js";
 import type { ToolScopeItemResponseModel, ToolItemResponseModel } from "../../api/types.gen.js";
 
+// Re-export types for use by other components
+export type { ToolScopeItemResponseModel, ToolItemResponseModel };
+
 /**
  * Repository for tool operations.
  */