fix use after free when DEBUG

niol · xrmx · commit 130e727807e4 · 2023-07-25T15:40:12.000+02:00
diff --git a/core/offload.c b/core/offload.c
@@ -236,11 +236,11 @@ static void uwsgi_offload_close(struct uwsgi_thread *ut, struct uwsgi_offload_re
 		close(uor->pipe[0]);
 	}
 
-	free(uor);
-
 #ifdef UWSGI_DEBUG
 	uwsgi_log("[offload] destroyed session %p\n", uor);
 #endif
+
+	free(uor);
 }
 
 static void uwsgi_offload_append(struct uwsgi_thread *ut, struct uwsgi_offload_request *uor) {

Original file line number	Diff line number	Diff line change
`@@ -236,11 +236,11 @@ static void uwsgi_offload_close(struct uwsgi_thread *ut, struct uwsgi_offload_re`
`236`	`236`	`close(uor->pipe[0]);`
`237`	`237`	`}`
`238`	`238`
`239`		`- free(uor);`
`240`		`-`
`241`	`239`	`#ifdef UWSGI_DEBUG`
`242`	`240`	`uwsgi_log("[offload] destroyed session %p\n", uor);`
`243`	`241`	`#endif`
	`242`	`+`
	`243`	`+ free(uor);`
`244`	`244`	`}`
`245`	`245`
`246`	`246`	`static void uwsgi_offload_append(struct uwsgi_thread ut, struct uwsgi_offload_request uor) {`