Remove pure option

Adhering with the updated react-redux API which [favors
composition](reduxjs/react-redux#507)

Author: Simen Brekken

README.md

@@ -13,7 +13,7 @@ npm install --save react-firebase
 
 ## Usage
 
-### `connect([mapFirebaseToProps], [options])`
+### `connect([mapFirebaseToProps])`
 
 Connects a React component to a Firebase App reference.
 
@@ -23,9 +23,6 @@ It does not modify the component class passed to it. Instead, it *returns* a new
 
 * [`mapFirebaseToProps(props, ref, firebaseApp): subscriptions`] \(*Object or Function*): Its result, or the argument itself must be a plain object. Each value must either be a path to a location in your database, a query object or a function. If you omit it, the default implementation just injects `firebaseApp` into your component’s props.
 
-* [`options`] *(Object)* If specified, further customizes the behavior of the connector.
-  * [`pure = true`] *(Boolean)*: If true, implements `shouldComponentUpdate`, preventing unnecessary updates, assuming that the component is a “pure” component and does not rely on any input or state other than its props and subscriptions. *Defaults to `true`.*
-
 #### Returns
 
 A React component class that injects subscriptions and actions into your component according to the specified options.

src/connect.js

@@ -1,6 +1,5 @@
 import firebase from 'firebase'
 import invariant from 'invariant'
-import shallowCompare from 'react/lib/shallowCompare'
 import { Component, createElement } from 'react'
 import { isFunction, isPlainObject, isString, keys, pickBy, omitBy, reduce } from 'lodash'
 import { firebaseAppShape } from './PropTypes'
@@ -21,12 +20,7 @@ const mapSubscriptionsToQueries = subscriptions => (
 
 const defaultMapFirebaseToProps = (props, ref, firebaseApp) => ({ firebaseApp })
 
-export default (
-  mapFirebaseToProps = defaultMapFirebaseToProps,
-  options = {}
-) => {
-  const { pure = true } = options
-
+export default (mapFirebaseToProps = defaultMapFirebaseToProps) => {
   const mapFirebase = (
     isFunction(mapFirebaseToProps) ? mapFirebaseToProps : () => mapFirebaseToProps
   )
@@ -70,17 +64,14 @@ export default (
       componentWillReceiveProps(nextProps) {
         const subscriptions = computeSubscriptions(this.props, this.ref, this.firebaseApp)
         const nextSubscriptions = computeSubscriptions(nextProps, this.ref, this.firebaseApp)
-
-        if (!pure || !shallowCompare(subscriptions, nextSubscriptions)) {
-          const addedSubscriptions = pickBy(nextSubscriptions, (path, key) => !subscriptions[key])
-          const removedSubscriptions = pickBy(subscriptions, (path, key) => !nextSubscriptions[key])
-          const changedSubscriptions = pickBy(nextSubscriptions, (path, key) => (
-            subscriptions[key] && subscriptions[key] !== path
-          ))
-
-          this.unsubscribe({ ...removedSubscriptions, ...changedSubscriptions })
-          this.subscribe({ ...addedSubscriptions, ...changedSubscriptions })
-        }
+        const addedSubscriptions = pickBy(nextSubscriptions, (path, key) => !subscriptions[key])
+        const removedSubscriptions = pickBy(subscriptions, (path, key) => !nextSubscriptions[key])
+        const changedSubscriptions = pickBy(nextSubscriptions, (path, key) => (
+          subscriptions[key] && subscriptions[key] !== path
+        ))
+
+        this.unsubscribe({ ...removedSubscriptions, ...changedSubscriptions })
+        this.subscribe({ ...addedSubscriptions, ...changedSubscriptions })
       }
 
       componentWillUnmount() {

src/tests/connect-test.js

@@ -186,5 +186,3 @@ test('Should pass props, ref and firebase to mapFirebaseToProps', assert => {
 })
 
 test('Should update subscriptions when props change')
-test('Should not re-render if options.pure is true')
-test('Should re-render if options.pure is false')