Merge pull request #90 from utopia-php/fix-default-id-padding

TorstenDittmann · web-flow · commit 102ee1d21fd5 · 2021-11-24T15:53:22.000+01:00
Fix: default to 20-char uniqids
diff --git a/src/Database/Database.php b/src/Database/Database.php
@@ -1180,7 +1180,7 @@ protected function decodeAttribute(string $name, $value, Document $document)
      *
      * @return string
      */
-    public function getId(int $padding = 0): string
+    public function getId(int $padding = 7): string
     {
         $uniqid = \uniqid();
 
diff --git a/tests/Database/Base.php b/tests/Database/Base.php
@@ -1683,7 +1683,7 @@ public function testGetIndexLimit()
 
     public function testGetId()
     {
-        $this->assertEquals(13, strlen($this->getDatabase()->getId()));
+        $this->assertEquals(20, strlen($this->getDatabase()->getId()));
         $this->assertEquals(13, strlen($this->getDatabase()->getId(0)));
         $this->assertEquals(13, strlen($this->getDatabase()->getId(-1)));
         $this->assertEquals(23, strlen($this->getDatabase()->getId(10)));

Original file line number	Diff line number	Diff line change
`@@ -1180,7 +1180,7 @@ protected function decodeAttribute(string $name, $value, Document $document)`
`1180`	`1180`	`*`
`1181`	`1181`	`* @return string`
`1182`	`1182`	`*/`
`1183`		`- public function getId(int $padding = 0): string`
	`1183`	`+ public function getId(int $padding = 7): string`
`1184`	`1184`	`{`
`1185`	`1185`	`$uniqid = \uniqid();`
`1186`	`1186`
Original file line number	Diff line number	Diff line change
`@@ -1683,7 +1683,7 @@ public function testGetIndexLimit()`
`1683`	`1683`
`1684`	`1684`	`public function testGetId()`
`1685`	`1685`	`{`
`1686`		`- $this->assertEquals(13, strlen($this->getDatabase()->getId()));`
	`1686`	`+ $this->assertEquals(20, strlen($this->getDatabase()->getId()));`
`1687`	`1687`	`$this->assertEquals(13, strlen($this->getDatabase()->getId(0)));`
`1688`	`1688`	`$this->assertEquals(13, strlen($this->getDatabase()->getId(-1)));`
`1689`	`1689`	`$this->assertEquals(23, strlen($this->getDatabase()->getId(10)));`