fixed the bug of status not updating and internal id not getting assigned to the documents

Author: ArnabChatterjee20k

src/Migration/Cache.php

@@ -30,14 +30,6 @@ public function __construct()
      */
     public function add(Resource $resource): void
     {
-        // if documents then storing the status counter only
-        if ($resource->getName() == Resource::TYPE_DOCUMENT) {
-            $status = $resource->getStatus();
-            $documentId = $resource->getInternalId();
-            $this->cache[$resource->getName()][$documentId] = $status;
-            return;
-        }
-
         if (! $resource->getInternalId()) {
             $resourceId = uniqid();
             if (isset($this->cache[$resource->getName()][$resourceId])) {
@@ -47,6 +39,13 @@ public function add(Resource $resource): void
             $resource->setInternalId(uniqid());
         }
 
+        if ($resource->getName() == Resource::TYPE_DOCUMENT) {
+            $status = $resource->getStatus();
+            $documentId = $resource->getInternalId();
+            $this->cache[$resource->getName()][$documentId] = $status;
+            return;
+        }
+
         if ($resource->getName() == Resource::TYPE_FILE || $resource->getName() == Resource::TYPE_DEPLOYMENT) {
             /** @var File|Deployment $resource */
             $resource->setData(''); // Prevent Memory Leak

src/Migration/Transfer.php

@@ -129,25 +129,24 @@ public function getStatusCounters(): array
                 }
             }
         }
-        
+
         foreach ($this->cache->getAll() as $resourceType => $resources) {
-            foreach ($resources as $resourceId => $resource) {
+            foreach ($resources as $resource) {
                 if ($resourceType === Resource::TYPE_DOCUMENT && is_string($resource)) {
                     $documentStatus = $resource;
                     $status[$resourceType][$documentStatus]++;
-                    
-                    if ($documentStatus === 'pending' && $status[$resourceType]['pending'] > 0) {
+
+                    if ($status[$resourceType]['pending'] > 0) {
                         $status[$resourceType]['pending']--;
                     }
-        
-                    continue; // Skip to next iteration
+
+                    continue;
                 }
-        
-                // For all other non-document resources
+
                 if (isset($status[$resource->getName()])) {
                     $status[$resource->getName()][$resource->getStatus()]++;
-        
-                    if ($resource->getStatus() === 'pending' && $status[$resource->getName()]['pending'] > 0) {
+
+                    if ($status[$resource->getName()]['pending'] > 0) {
                         $status[$resource->getName()]['pending']--;
                     }
                 }
@@ -270,46 +269,46 @@ public function getCurrentResource(): string
      * @param  string  $statusLevel If no status level is provided, all status types will be returned.
      * @return array<array<string, mixed>>
      */
-public function getReport(string $statusLevel = ''): array
-{
-    $report = [];
-    $cache = $this->cache->getAll();
+    public function getReport(string $statusLevel = ''): array
+    {
+        $report = [];
+        $cache = $this->cache->getAll();
+
+        foreach ($cache as $type => $resources) {
+            foreach ($resources as $id => $resource) {
+                if ($type === Resource::TYPE_DOCUMENT && is_string($resource)) {
+                    if ($statusLevel && $resource !== $statusLevel) {
+                        continue;
+                    }
+                    // no message for document is stored
+                    $report[] = [
+                        'resource' => $type,
+                        'id' => $id,
+                        'status' => $resource,
+                        'message' => '',
+                    ];
+                    continue;
+                }
+
+                if (!is_object($resource)) {
+                    continue;
+                }
 
-    foreach ($cache as $type => $resources) {
-        foreach ($resources as $id => $resource) {
-            if ($type === Resource::TYPE_DOCUMENT && is_string($resource)) {
-                if ($statusLevel && $resource !== $statusLevel) {
+                if ($statusLevel && $resource->getStatus() !== $statusLevel) {
                     continue;
                 }
-                // no message for document is stored
+
                 $report[] = [
                     'resource' => $type,
-                    'id' => $id,
-                    'status' => $resource,
-                    'message' => '',
+                    'id' => $resource->getId(),
+                    'status' => $resource->getStatus(),
+                    'message' => $resource->getMessage(),
                 ];
-                continue;
-            }
-
-            if (!is_object($resource)) {
-                continue;
-            }
-
-            if ($statusLevel && $resource->getStatus() !== $statusLevel) {
-                continue;
             }
-
-            $report[] = [
-                'resource' => $type,
-                'id' => $resource->getId(),
-                'status' => $resource->getStatus(),
-                'message' => $resource->getMessage(),
-            ];
         }
-    }
 
-    return $report;
-}
+        return $report;
+    }
 
     /**
      * @throws \Exception