fix: add TS unit test, pin to typescript@5.0.4 (#860)

broofa · web-flow · commit 24ac2fd067e5 · 2025-01-09T12:36:11.000-10:00
diff --git a/examples/benchmark/package.json b/examples/benchmark/package.json
@@ -5,7 +5,7 @@
   "scripts": {
     "build": "true",
     "start": "npm run build && npx http-server . -o",
-    "pretest": "HUSKY=0 npm install --no-package-lock",
+    "pretest": "rm -fr node_modules && npm install --no-package-lock",
     "test": "node node.js"
   },
   "dependencies": {
diff --git a/examples/browser-rollup/package.json b/examples/browser-rollup/package.json
@@ -3,7 +3,7 @@
   "version": "0.0.0",
   "private": true,
   "scripts": {
-    "build": "npm install --no-package-lock && rm -rf dist && rollup -c",
+    "build": "rm -fr node_modules && npm install --no-package-lock && rm -rf dist && rollup -c",
     "start": "npm run build && npx http-server . -o"
   },
   "dependencies": {
diff --git a/examples/browser-webpack/package.json b/examples/browser-webpack/package.json
@@ -3,7 +3,7 @@
   "version": "0.0.0",
   "private": true,
   "scripts": {
-    "build": "npm install --no-package-lock && rm -rf dist && webpack",
+    "build": "rm -fr node_modules && npm install --no-package-lock && rm -rf dist && webpack",
     "start": "npm run build && npx http-server . -o"
   },
   "dependencies": {
diff --git a/examples/node-commonjs/package.json b/examples/node-commonjs/package.json
@@ -3,7 +3,7 @@
   "version": "0.0.0",
   "private": true,
   "scripts": {
-    "pretest": "npm install --no-package-lock",
+    "pretest": "rm -fr node_modules && npm install --no-package-lock",
     "test": "node example.js"
   },
   "dependencies": {
diff --git a/examples/node-esmodules/package.json b/examples/node-esmodules/package.json
@@ -5,7 +5,7 @@
   "scripts": {
     "test:package": "( node --version | grep -vq 'v16' ) || ( node --experimental-json-modules package.mjs )",
     "test:example": "node example.mjs",
-    "pretest": "npm install --no-package-lock",
+    "pretest": "rm -fr node_modules && npm install --no-package-lock",
     "test": "npm-run-all test:*"
   },
   "dependencies": {
diff --git a/examples/node-jest/package.json b/examples/node-jest/package.json
@@ -3,7 +3,7 @@
   "version": "0.0.0",
   "private": true,
   "scripts": {
-    "pretest": "npm install --no-package-lock",
+    "pretest": "rm -fr node_modules && npm install --no-package-lock",
     "test": "jest"
   },
   "dependencies": {
diff --git a/examples/node-webpack/package.json b/examples/node-webpack/package.json
@@ -4,7 +4,7 @@
   "private": true,
   "scripts": {
     "build": "rm -rf dist && webpack",
-    "pretest": "npm install --no-package-lock",
+    "pretest": "rm -fr node_modules && npm install --no-package-lock",
     "test": "npm run build && node dist/v1.js && node dist/v4.js && node dist/v7.js && node dist/all.js"
   },
   "dependencies": {
diff --git a/examples/typescript/README.md b/examples/typescript/README.md
@@ -0,0 +1,8 @@
+# uuid test for typescript support (not really an example)
+
+```
+npm install
+npm test
+```
+
+This runs `tsc` using the oldest version of TypeScript supported by this project
diff --git a/examples/typescript/index.ts b/examples/typescript/index.ts
@@ -0,0 +1,3 @@
+import * as uuid from 'uuid';
+
+console.log(uuid);
diff --git a/examples/typescript/package.json b/examples/typescript/package.json
@@ -0,0 +1,9 @@
+{
+  "dependencies": {
+    "uuid": "file:../../.build/uuid.tgz"
+  },
+  "scripts": {
+    "pretest": "rm -fr node_modules && npm install --no-package-lock",
+    "test": "npx -y --package=typescript@5.0.4 -- tsc --noEmit"
+  }
+}
diff --git a/examples/typescript/tsconfig.json b/examples/typescript/tsconfig.json
@@ -0,0 +1 @@
+{}
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -68,7 +68,7 @@
     "release-please": "16.15.0",
     "runmd": "1.4.1",
     "standard-version": "9.5.0",
-    "typescript": "5.7.2",
+    "typescript": "5.0.4",
     "typescript-eslint": "8.18.2"
   },
   "optionalDevDependencies": {
@@ -92,21 +92,22 @@
     "examples:node:commonjs:test": "cd examples/node-commonjs && npm test",
     "examples:node:esmodules:test": "cd examples/node-esmodules && npm test",
     "examples:node:jest:test": "cd examples/node-jest && npm test",
+    "examples:node:typescript:test": "cd examples/typescript && npm test",
     "lint": "npm run eslint:check && npm run prettier:check",
     "md": "runmd --watch --output=README.md README_js.md",
     "prepack": "npm run build -- --no-pack",
     "prepare": "husky",
     "prepublishOnly": "npm run build",
     "pretest:benchmark": "npm run build",
-    "pretest:browser": "./scripts/iodd && npm run build && npm-run-all examples:browser:**",
+    "pretest:browser": "./scripts/iodd && npm run build && npm-run-all --parallel examples:browser:**",
     "pretest:node": "npm run build",
     "pretest": "npm run build",
     "prettier:check": "prettier --check .",
     "prettier:fix": "prettier --write .",
     "release": "standard-version --no-verify",
     "test:benchmark": "cd examples/benchmark && npm test",
     "test:browser": "wdio run ./wdio.conf.js",
-    "test:node": "npm-run-all examples:node:**",
+    "test:node": "npm-run-all --parallel examples:node:**",
     "test:watch": "node --test --enable-source-maps --watch dist/esm/test/*.js",
     "test": "node --test --enable-source-maps dist/esm/test/*.js"
   },
diff --git a/scripts/build.sh b/scripts/build.sh
@@ -63,8 +63,8 @@ done
 if [ "${1-}" != "--no-pack" ]; then
   # Prep tarball dir
   BUILD_DIR="$ROOT/.build"
+  rm -rf "$BUILD_DIR"
   mkdir -p "$BUILD_DIR"
-  rm -rf "$BUILD_DIR/uuid-*.tgz"
 
   # Create tarball for local installation (in tests and examples)
   echo "Packing tarball"
diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -5,5 +5,6 @@
     "skipLibCheck": true,
     "strict": true,
     "target": "ES2022"
-  }
+  },
+  "exclude": ["dist", "examples"]
 }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+import * as uuid from 'uuid';`
	`2`	`+`
	`3`	`+console.log(uuid);`