Skip to content

Commit 4bca489

Browse files
Krysztal112233sylvestre
authored andcommitted
uucore: Move tests for Teletypeto tty.rs
1 parent 58d0fb6 commit 4bca489

File tree

3 files changed

+37
-32
lines changed

3 files changed

+37
-32
lines changed

src/uucore/src/lib/features.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ pub mod perms;
4747
pub mod pipes;
4848
#[cfg(all(target_os = "linux", feature = "proc-info"))]
4949
pub mod proc_info;
50-
#[cfg(all(target_os = "linux", feature = "tty"))]
51-
pub mod tty;
5250
#[cfg(all(unix, feature = "process"))]
5351
pub mod process;
52+
#[cfg(all(target_os = "linux", feature = "tty"))]
53+
pub mod tty;
5454

5555
#[cfg(all(unix, not(target_os = "macos"), feature = "fsxattr"))]
5656
pub mod fsxattr;

src/uucore/src/lib/features/proc_info.rs

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -350,35 +350,6 @@ mod tests {
350350
use super::*;
351351
use std::str::FromStr;
352352

353-
#[test]
354-
fn test_tty_from() {
355-
assert_eq!(Teletype::try_from("?").unwrap(), Teletype::Unknown);
356-
assert_eq!(Teletype::try_from("/dev/tty1").unwrap(), Teletype::Tty(1));
357-
assert_eq!(Teletype::try_from("/dev/tty10").unwrap(), Teletype::Tty(10));
358-
assert_eq!(Teletype::try_from("/dev/pts/1").unwrap(), Teletype::Pts(1));
359-
assert_eq!(
360-
Teletype::try_from("/dev/pts/10").unwrap(),
361-
Teletype::Pts(10)
362-
);
363-
assert_eq!(Teletype::try_from("/dev/ttyS1").unwrap(), Teletype::TtyS(1));
364-
assert_eq!(
365-
Teletype::try_from("/dev/ttyS10").unwrap(),
366-
Teletype::TtyS(10)
367-
);
368-
assert_eq!(Teletype::try_from("ttyS10").unwrap(), Teletype::TtyS(10));
369-
370-
assert!(Teletype::try_from("value").is_err());
371-
assert!(Teletype::try_from("TtyS10").is_err());
372-
}
373-
374-
#[test]
375-
fn test_terminal_type_display() {
376-
assert_eq!(Teletype::Pts(10).to_string(), "/dev/pts/10");
377-
assert_eq!(Teletype::Tty(10).to_string(), "/dev/tty10");
378-
assert_eq!(Teletype::TtyS(10).to_string(), "/dev/ttyS10");
379-
assert_eq!(Teletype::Unknown.to_string(), "?");
380-
}
381-
382353
#[test]
383354
fn test_run_state_conversion() {
384355
assert_eq!(RunState::try_from("R").unwrap(), RunState::Running);
@@ -431,7 +402,7 @@ mod tests {
431402
.flat_map(Teletype::try_from)
432403
.collect::<HashSet<_>>();
433404

434-
assert_eq!(pid_entry.ttys().unwrap(), result.into())
405+
assert_eq!(pid_entry.ttys().unwrap(), result.into());
435406
}
436407

437408
#[test]

src/uucore/src/lib/features/tty.rs

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,3 +91,37 @@ impl TryFrom<PathBuf> for Teletype {
9191
}
9292
}
9393
}
94+
95+
#[cfg(test)]
96+
mod tests {
97+
use super::*;
98+
99+
#[test]
100+
fn test_tty_from() {
101+
assert_eq!(Teletype::try_from("?").unwrap(), Teletype::Unknown);
102+
assert_eq!(Teletype::try_from("/dev/tty1").unwrap(), Teletype::Tty(1));
103+
assert_eq!(Teletype::try_from("/dev/tty10").unwrap(), Teletype::Tty(10));
104+
assert_eq!(Teletype::try_from("/dev/pts/1").unwrap(), Teletype::Pts(1));
105+
assert_eq!(
106+
Teletype::try_from("/dev/pts/10").unwrap(),
107+
Teletype::Pts(10)
108+
);
109+
assert_eq!(Teletype::try_from("/dev/ttyS1").unwrap(), Teletype::TtyS(1));
110+
assert_eq!(
111+
Teletype::try_from("/dev/ttyS10").unwrap(),
112+
Teletype::TtyS(10)
113+
);
114+
assert_eq!(Teletype::try_from("ttyS10").unwrap(), Teletype::TtyS(10));
115+
116+
assert!(Teletype::try_from("value").is_err());
117+
assert!(Teletype::try_from("TtyS10").is_err());
118+
}
119+
120+
#[test]
121+
fn test_terminal_type_display() {
122+
assert_eq!(Teletype::Pts(10).to_string(), "/dev/pts/10");
123+
assert_eq!(Teletype::Tty(10).to_string(), "/dev/tty10");
124+
assert_eq!(Teletype::TtyS(10).to_string(), "/dev/ttyS10");
125+
assert_eq!(Teletype::Unknown.to_string(), "?");
126+
}
127+
}

0 commit comments

Comments
 (0)