Skip to content

chroot: resolve all ids before chroot#11211

Merged
sylvestre merged 1 commit into
uutils:mainfrom
victor-prokhorov:chroot-fix-nss-injection
May 20, 2026
Merged

chroot: resolve all ids before chroot#11211
sylvestre merged 1 commit into
uutils:mainfrom
victor-prokhorov:chroot-fix-nss-injection

Conversation

@victor-prokhorov

@victor-prokhorov victor-prokhorov commented Mar 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #10327

@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)

@codspeed-hq

codspeed-hq Bot commented Mar 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 297 untouched benchmarks
⏩ 48 skipped benchmarks1

Comparing victor-prokhorov:chroot-fix-nss-injection (7049306) with main (f0c71b2)

Open in CodSpeed

Footnotes

  1. 48 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@xtqqczze xtqqczze mentioned this pull request Mar 6, 2026
Merged
@victor-prokhorov victor-prokhorov force-pushed the chroot-fix-nss-injection branch from 6f04211 to 7049306 Compare March 6, 2026 17:21
@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

@victor-prokhorov victor-prokhorov marked this pull request as ready for review March 6, 2026 18:21
sylvestre
sylvestre approved these changes May 20, 2026
View reviewed changes

@sylvestre sylvestre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — resolving user/group names before entering the chroot is the right approach since /etc/passwd may not exist inside. Matches GNU.

@sylvestre sylvestre merged commit f33bfb9 into uutils:main May 20, 2026
163 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chroot --userspec NSS Injection Before Privilege Drop (glibc)

2 participants

@victor-prokhorov @sylvestre