Skip to content

Commit 461d55e

Browse files
ankalininvpirogov
authored andcommitted
x64: brgemm convolution: fix postops kernel creation condition
1 parent c8943f5 commit 461d55e

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

src/cpu/x64/jit_brgemm_conv.cpp

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -654,10 +654,13 @@ status_t brgemm_convolution_fwd_t<isa, use_inversion>::init(engine_t *engine) {
654654
for_(int i_N = N_begin; i_N < N_end; i_N++)
655655
for (int i_M = M_begin; i_M < M_end; i_M++) {
656656
// init "init" and "po" kernels for cases then we never call brgemm kernels
657-
// e.g. for d/h padded areas
658-
const bool filter_in_padding = jcp.f_pad > EXT_KD
659-
|| jcp.back_pad > EXT_KD || jcp.t_pad > EXT_KH
660-
|| jcp.b_pad > EXT_KH;
657+
// e.g. for d/h padded and dilated filter areas
658+
const bool filter_in_padding = jcp.f_pad >= EXT_KD
659+
|| jcp.back_pad >= EXT_KD || jcp.t_pad >= EXT_KH
660+
|| jcp.b_pad >= EXT_KH;
661+
// note: overly simplistic condition. Ideally, the condition would
662+
// only detect cases where there is strictly no overlap between the
663+
// input and filter.
661664
const bool dilate_no_overlap
662665
= jcp.dilate_d >= jcp.id || jcp.dilate_h >= jcp.ih;
663666
if (IMPLICATION(jcp.exec_type == exec_trans,

0 commit comments

Comments
 (0)