Skip to content

Commit 8e2c8b0

Browse files
victorgomespthier
authored andcommitted
Migrate to a new V8 interceptors Api (#180)
The new callback should return v8::Intercepted::kYes/kNo to indicate whether the operation was intercepted. This replaces the old approach where the callback had to leave the return value unset or set it to an empty handle to indicate that the the request wasn't intercepted. See https://crrev.com/c/5465509 and https://crrev.com/c/5465513. # Conflicts: # src/node_contextify.cc # Conflicts: # src/node_contextify.cc # src/node_env_var.cc
1 parent af18d06 commit 8e2c8b0

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/node_env_var.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,6 @@ static Intercepted EnvSetter(Local<Name> property,
386386
}
387387

388388
env->env_vars()->Set(env->isolate(), key, value_string);
389-
390389
return Intercepted::kYes;
391390
}
392391

0 commit comments

Comments
 (0)