Skip to content

Commit b005bfd

Browse files
committed
[platform] Override CreateJob instead of PostJob
PostJob will call out to CreateJob in its default implementation, so it's sufficient to only override CreateJob. The default implementation of CreateJob will return a nullptr though, so we cannot use it in V8 before Node overrides it.
1 parent 11bb61b commit b005bfd

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/node_platform.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -518,7 +518,7 @@ bool NodePlatform::FlushForegroundTasks(Isolate* isolate) {
518518
return per_isolate->FlushForegroundTasksInternal();
519519
}
520520

521-
std::unique_ptr<v8::JobHandle> NodePlatform::PostJob(v8::TaskPriority priority,
521+
std::unique_ptr<v8::JobHandle> NodePlatform::CreateJob(v8::TaskPriority priority,
522522
std::unique_ptr<v8::JobTask> job_task) {
523523
return v8::platform::NewDefaultJobHandle(
524524
this, priority, std::move(job_task), NumberOfWorkerThreads());

src/node_platform.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ class NodePlatform : public MultiIsolatePlatform {
155155
double CurrentClockTimeMillis() override;
156156
v8::TracingController* GetTracingController() override;
157157
bool FlushForegroundTasks(v8::Isolate* isolate) override;
158-
std::unique_ptr<v8::JobHandle> PostJob(
158+
std::unique_ptr<v8::JobHandle> CreateJob(
159159
v8::TaskPriority priority,
160160
std::unique_ptr<v8::JobTask> job_task) override;
161161

0 commit comments

Comments
 (0)