Skip to content

Commit a417b41

Browse files
dslomovCommit bot
authored and
Commit bot
committed
Unship ES6 classes.
[email protected] BUG=v8:3330 Review URL: https://codereview.chromium.org/836393003 Cr-Commit-Position: refs/heads/master@{#26000}
1 parent 3783de4 commit a417b41

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

src/flag-definitions.h

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -183,16 +183,17 @@ DEFINE_IMPLICATION(es_staging, harmony)
183183
V(harmony_unicode, "harmony unicode escapes")
184184

185185
// Features that are complete (but still behind --harmony/es-staging flag).
186-
#define HARMONY_STAGED(V) V(harmony_tostring, "harmony toString")
186+
#define HARMONY_STAGED(V) \
187+
V(harmony_tostring, "harmony toString") \
188+
V(harmony_classes, \
189+
"harmony classes (implies block scoping & object literal extension)") \
190+
V(harmony_object_literals, "harmony object literal extensions")
187191

188192
// Features that are shipping (turned on by default, but internal flag remains).
189193
#define HARMONY_SHIPPING(V) \
190194
V(harmony_numeric_literals, "harmony numeric literals") \
191195
V(harmony_strings, "harmony string methods") \
192196
V(harmony_scoping, "harmony block scoping") \
193-
V(harmony_classes, \
194-
"harmony classes (implies block scoping & object literal extension)") \
195-
V(harmony_object_literals, "harmony object literal extensions") \
196197
V(harmony_templates, "harmony template literals")
197198

198199
// Once a shipping feature has proved stable in the wild, it will be dropped

test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ PASS getSortedOwnPropertyNames(encodeURIComponent) is ['arguments', 'caller', 'l
4747
PASS getSortedOwnPropertyNames(Object) is ['arguments', 'caller', 'create', 'defineProperties', 'defineProperty', 'deliverChangeRecords', 'freeze', 'getNotifier', 'getOwnPropertyDescriptor', 'getOwnPropertyNames', 'getOwnPropertySymbols', 'getPrototypeOf', 'is', 'isExtensible', 'isFrozen', 'isSealed', 'keys', 'length', 'name', 'observe', 'preventExtensions', 'prototype', 'seal', 'setPrototypeOf', 'unobserve']
4848
PASS getSortedOwnPropertyNames(Object.prototype) is ['__defineGetter__', '__defineSetter__', '__lookupGetter__', '__lookupSetter__', '__proto__', 'constructor', 'hasOwnProperty', 'isPrototypeOf', 'propertyIsEnumerable', 'toLocaleString', 'toString', 'valueOf']
4949
PASS getSortedOwnPropertyNames(Function) is ['arguments', 'caller', 'length', 'name', 'prototype']
50-
PASS getSortedOwnPropertyNames(Function.prototype) is ['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toMethod', 'toString']
50+
PASS getSortedOwnPropertyNames(Function.prototype) is ['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toString']
5151
PASS getSortedOwnPropertyNames(Array) is ['arguments', 'caller', 'isArray', 'length', 'name', 'observe', 'prototype', 'unobserve']
5252
PASS getSortedOwnPropertyNames(Array.prototype) is ['concat', 'constructor', 'entries', 'every', 'filter', 'forEach', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift']
5353
PASS getSortedOwnPropertyNames(String) is ['arguments', 'caller', 'fromCharCode', 'fromCodePoint', 'length', 'name', 'prototype', 'raw']

test/webkit/fast/js/Object-getOwnPropertyNames.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ var expectedPropertyNamesSet = {
7474
"Object": "['arguments', 'caller', 'create', 'defineProperties', 'defineProperty', 'deliverChangeRecords', 'freeze', 'getNotifier', 'getOwnPropertyDescriptor', 'getOwnPropertyNames', 'getOwnPropertySymbols', 'getPrototypeOf', 'is', 'isExtensible', 'isFrozen', 'isSealed', 'keys', 'length', 'name', 'observe', 'preventExtensions', 'prototype', 'seal', 'setPrototypeOf', 'unobserve']",
7575
"Object.prototype": "['__defineGetter__', '__defineSetter__', '__lookupGetter__', '__lookupSetter__', '__proto__', 'constructor', 'hasOwnProperty', 'isPrototypeOf', 'propertyIsEnumerable', 'toLocaleString', 'toString', 'valueOf']",
7676
"Function": "['arguments', 'caller', 'length', 'name', 'prototype']",
77-
"Function.prototype": "['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toMethod', 'toString']",
77+
"Function.prototype": "['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toString']",
7878
"Array": "['arguments', 'caller', 'isArray', 'length', 'name', 'observe', 'prototype', 'unobserve']",
7979
"Array.prototype": "['concat', 'constructor', 'entries', 'every', 'filter', 'forEach', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift']",
8080
"String": "['arguments', 'caller', 'fromCharCode', 'fromCodePoint', 'length', 'name', 'prototype', 'raw']",

0 commit comments

Comments
 (0)