[wasm-simd][ia32] Fix all_true operand to be register

ngzhian · Commit Bot · commit d4b58fec7d70 · 2020-05-27T22:34:58.000Z
all_true uses pcmpeqd which takes a memory operand, but needs to be 128-bit aligned, which we don't support yet. Bug: v8:9198 Change-Id: Ia0caaaa76b1103ba538252181ef93e8557fb4739 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2218887 Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68027}
diff --git a/src/compiler/backend/ia32/instruction-selector-ia32.cc b/src/compiler/backend/ia32/instruction-selector-ia32.cc
@@ -2407,7 +2407,7 @@ SIMD_ANYTRUE_LIST(VISIT_SIMD_ANYTRUE)
     IA32OperandGenerator g(this);                                             \
     InstructionOperand temps[] = {g.TempRegister(), g.TempSimd128Register()}; \
     Emit(kIA32##Opcode, g.DefineAsRegister(node),                             \
-         g.UseUnique(node->InputAt(0)), arraysize(temps), temps);             \
+         g.UseUniqueRegister(node->InputAt(0)), arraysize(temps), temps);     \
   }
 SIMD_ALLTRUE_LIST(VISIT_SIMD_ALLTRUE)
 #undef VISIT_SIMD_ALLTRUE

Original file line number	Diff line number	Diff line change
`@@ -2407,7 +2407,7 @@ SIMD_ANYTRUE_LIST(VISIT_SIMD_ANYTRUE)`
`2407`	`2407`	`IA32OperandGenerator g(this); \`
`2408`	`2408`	`InstructionOperand temps[] = {g.TempRegister(), g.TempSimd128Register()}; \`
`2409`	`2409`	`Emit(kIA32##Opcode, g.DefineAsRegister(node), \`
`2410`		`- g.UseUnique(node->InputAt(0)), arraysize(temps), temps); \`
	`2410`	`+ g.UseUniqueRegister(node->InputAt(0)), arraysize(temps), temps); \`
`2411`	`2411`	`}`
`2412`	`2412`	`SIMD_ALLTRUE_LIST(VISIT_SIMD_ALLTRUE)`
`2413`	`2413`	`#undef VISIT_SIMD_ALLTRUE`