fix(isBtcAddress): add base58 (#1548)

Author: ezkemboi

src/lib/isBtcAddress.js

@@ -1,9 +1,14 @@
 import assertString from './util/assertString';
 
 // supports Bech32 addresses
-const btc = /^(bc1|[13])[a-zA-HJ-NP-Z0-9]{25,39}$/;
+const bech32 = /^(bc1)[a-z0-9]{25,39}$/;
+const base58 = /^(1|3)[A-HJ-NP-Za-km-z1-9]{25,39}$/;
 
 export default function isBtcAddress(str) {
   assertString(str);
-  return btc.test(str);
+  // check for bech32
+  if (str.startsWith('bc1')) {
+    return bech32.test(str);
+  }
+  return base58.test(str);
 }

test/validators.js

@@ -8470,11 +8470,17 @@ describe('Validators', () => {
         '1MUz4VMYui5qY1mxUiG8BQ1Luv6tqkvaiL',
         '3J98t1WpEZ73CNmQviecrnyiWrnqRhWNLy',
         'bc1qar0srrr7xfkvy5l643lydnw9re59gtzzwf5mdq',
+        '14qViLJfdGaP4EeHnDyJbEGQysnCpwk3gd',
+        '35bSzXvRKLpHsHMrzb82f617cV4Srnt7hS',
+        '17VZNX1SN5NtKa8UQFxwQbFeFc3iqRYhemt',
+        'bc1qw508d6qejxtdg4y5r3zarvary0c5xw7kv8f3t4',
       ],
       invalid: [
         '4J98t1WpEZ73CNmQviecrnyiWrnqRhWNLy',
         '0x56F0B8A998425c53c75C4A303D4eF987533c5597',
         'pp8skudq3x5hzw8ew7vzsw8tn4k8wxsqsv0lt0mf3g',
+        '17VZNX1SN5NlKa8UQFxwQbFeFc3iqRYhem',
+        'BC1QW508D6QEJXTDG4Y5R3ZARVAYR0C5XW7KV8F3T4',
       ],
     });
   });

validator.js

@@ -4000,10 +4000,19 @@ function isCurrency(str, options) {
   return currencyRegex(options).test(str);
 }
 
-var btc = /^(bc1|[13])[a-zA-HJ-NP-Z0-9]{25,39}$/;
+var bech32 = /^(bc1)[a-z0-9]{25,39}$/;
+var base58 = /^(1|3)[A-HJ-NP-Za-km-z1-9]{25,39}$/;
 function isBtcAddress(str) {
-  assertString(str);
-  return btc.test(str);
+  assertString(str); // check for bech32
+
+  if (str.startsWith('bc1')) {
+    console.log({
+      str: str
+    });
+    return bech32.test(str);
+  }
+
+  return base58.test(str);
 }
 
 /* eslint-disable max-len */