addressing comments

Signed-off-by: TJ Zhang <tj.zhang@improving.com>

Author: tjzhang-BQ

go/api/base_client.go

@@ -7921,6 +7921,10 @@ func (client *baseClient) FunctionList(query FunctionListQuery) ([]LibraryInfo,
 
 // Returns the serialized payload of all loaded libraries.
 //
+// Note:
+//
+//	When in cluster mode, the command will be routed to a random node.
+//
 // Since:
 //
 //	Valkey 7.0 and above.
@@ -7942,6 +7946,10 @@ func (client *baseClient) FunctionDump() (string, error) {
 
 // Restores libraries from the serialized payload returned by `FunctionDump`.
 //
+// Note:
+//
+//	When in cluster mode, the command will be routed to all primary nodes.
+//
 // Since:
 //
 //	Valkey 7.0 and above.
@@ -7967,6 +7975,10 @@ func (client *baseClient) FunctionRestore(payload string) (string, error) {
 
 // Restores libraries from the serialized payload returned by `FunctionDump`.
 //
+// Note:
+//
+//	When in cluster mode, the command will be routed to all primary nodes.
+//
 // Since:
 //
 //	Valkey 7.0 and above.

go/api/scripting_and_function_commands_test.go

@@ -858,141 +858,125 @@ func ExampleGlideClusterClient_FunctionListWithRoute() {
 func ExampleGlideClient_FunctionDump() {
 	client := getExampleGlideClient()
 
-	// First, flush all functions
-	_, err := client.FunctionFlushSync()
+	// Attempt to call a non-existent function
+	_, err := client.FCall("nonexistent_function")
 	if err != nil {
-		fmt.Println("Glide example failed with an error: ", err)
-		return
+		fmt.Println("Error:", err.Error())
 	}
 
-	// Load a function
-	_, err = client.FunctionLoad(libraryCodeWithArgs, true)
-	if err != nil {
-		fmt.Println("Glide example failed with an error: ", err)
-		return
-	}
-
-	// Dump the functions
-	dump, err := client.FunctionDump()
-	if err != nil {
-		fmt.Println("Glide example failed with an error: ", err)
-		return
-	}
+	// Output:
+	// Error: An error was signalled by the server: - ResponseError: Function not found
+}
 
-	// Flush all functions
-	_, err = client.FunctionFlushSync()
-	if err != nil {
-		fmt.Println("Glide example failed with an error: ", err)
-		return
-	}
+func ExampleGlideClusterClient_FunctionDump() {
+	client := getExampleGlideClusterClient()
 
-	// Restore the functions
-	result, err := client.FunctionRestore(dump)
+	// Attempt to call a non-existent function
+	_, err := client.FCall("nonexistent_function")
 	if err != nil {
-		fmt.Println("Glide example failed with an error: ", err)
-		return
+		fmt.Println("Error:", err.Error())
 	}
 
-	fmt.Println(result)
-
 	// Output:
-	// OK
+	// Error: An error was signalled by the server: - ResponseError: Function not found
 }
 
-func ExampleGlideClusterClient_FunctionDump() {
+func ExampleGlideClusterClient_FunctionDumpWithRoute() {
 	client := getExampleGlideClusterClient()
 
-	// First, flush all functions
-	_, err := client.FunctionFlushSync()
+	// Attempt to call a non-existent function with route
+	route := options.RouteOption{Route: config.RandomRoute}
+	_, err := client.FCallWithRoute("nonexistent_function", route)
 	if err != nil {
-		fmt.Println("Glide example failed with an error: ", err)
-		return
+		fmt.Println("Error:", err.Error())
 	}
 
-	// Load a function
-	_, err = client.FunctionLoad(libraryCodeWithArgs, true)
-	if err != nil {
-		fmt.Println("Glide example failed with an error: ", err)
-		return
-	}
+	// Output:
+	// Error: An error was signalled by the server: - ResponseError: Function not found
+}
 
-	// Dump the functions
-	dump, err := client.FunctionDump()
-	if err != nil {
-		fmt.Println("Glide example failed with an error: ", err)
-		return
-	}
+func ExampleGlideClient_FunctionRestore() {
+	client := getExampleGlideClient()
 
-	// Flush all functions
-	_, err = client.FunctionFlushSync()
+	// Attempt to restore with invalid dump data
+	invalidDump := "invalid_dump_data"
+	_, err := client.FunctionRestore(invalidDump)
 	if err != nil {
-		fmt.Println("Glide example failed with an error: ", err)
-		return
+		fmt.Println("Error:", err.Error())
 	}
 
-	// Restore the functions with FLUSH policy to ensure clean restore
-	result, err := client.FunctionRestoreWithPolicy(dump, options.FlushPolicy)
+	// Output:
+	// Error: An error was signalled by the server: - ResponseError: DUMP payload version or checksum are wrong
+}
+
+func ExampleGlideClusterClient_FunctionRestore() {
+	client := getExampleGlideClusterClient()
+
+	// Attempt to restore with invalid dump data
+	invalidDump := "invalid_dump_data"
+	_, err := client.FunctionRestore(invalidDump)
 	if err != nil {
-		fmt.Println("Glide example failed with an error: ", err)
-		return
+		fmt.Println("Error:", err.Error())
 	}
 
-	fmt.Println(result)
-
 	// Output:
-	// OK
+	// Error: An error was signalled by the server: - ResponseError: DUMP payload version or checksum are wrong
 }
 
-func ExampleGlideClusterClient_FunctionDumpWithRoute() {
+func ExampleGlideClusterClient_FunctionRestoreWithRoute() {
 	client := getExampleGlideClusterClient()
 
-	// Use AllPrimaries route for cluster-wide operations
-	route := options.RouteOption{Route: config.AllPrimaries}
-
-	// First, flush all functions
-	_, err := client.FunctionFlushSyncWithRoute(route)
+	// Attempt to restore with invalid dump data and route
+	invalidDump := "invalid_dump_data"
+	route := config.RandomRoute
+	_, err := client.FunctionRestoreWithRoute(invalidDump, route)
 	if err != nil {
-		fmt.Println("Glide example failed with an error: ", err)
-		return
+		fmt.Println("Error:", err.Error())
 	}
 
-	// Load a function
-	// 	code := `#!lua name=mylib
-	// redis.register_function{
-	// 	function_name = 'myfunc',
-	// 	callback = function(keys, args) return args[1] end,
-	// 	flags = { 'no-writes' }
-	// }`
+	// Output:
+	// Error: An error was signalled by the server: - ResponseError: DUMP payload version or checksum are wrong
+}
 
-	_, err = client.FunctionLoadWithRoute(libraryCodeWithArgs, true, route)
-	if err != nil {
-		fmt.Println("Glide example failed with an error: ", err)
-		return
-	}
+func ExampleGlideClient_FunctionRestoreWithPolicy() {
+	client := getExampleGlideClient()
 
-	// Dump the functions from a single node
-	dump, err := client.FunctionDumpWithRoute(config.RandomRoute)
+	// Attempt to restore with invalid dump data and policy
+	invalidDump := "invalid_dump_data"
+	_, err := client.FunctionRestoreWithPolicy(invalidDump, options.FlushPolicy)
 	if err != nil {
-		fmt.Println("Glide example failed with an error: ", err)
-		return
+		fmt.Println("Error:", err.Error())
 	}
 
-	// Flush all functions
-	_, err = client.FunctionFlushSyncWithRoute(route)
+	// Output:
+	// Error: An error was signalled by the server: - ResponseError: DUMP payload version or checksum are wrong
+}
+
+func ExampleGlideClusterClient_FunctionRestoreWithPolicy() {
+	client := getExampleGlideClusterClient()
+
+	// Attempt to restore with invalid dump data and policy
+	invalidDump := "invalid_dump_data"
+	_, err := client.FunctionRestoreWithPolicy(invalidDump, options.FlushPolicy)
 	if err != nil {
-		fmt.Println("Glide example failed with an error: ", err)
-		return
+		fmt.Println("Error:", err.Error())
 	}
 
-	// Restore the functions with FLUSH policy to ensure clean restore
-	result, err := client.FunctionRestoreWithPolicyWithRoute(dump.SingleValue(), options.FlushPolicy, route.Route)
+	// Output:
+	// Error: An error was signalled by the server: - ResponseError: DUMP payload version or checksum are wrong
+}
+
+func ExampleGlideClusterClient_FunctionRestoreWithPolicyWithRoute() {
+	client := getExampleGlideClusterClient()
+
+	// Attempt to restore with invalid dump data, policy and route
+	invalidDump := "invalid_dump_data"
+	route := config.RandomRoute
+	_, err := client.FunctionRestoreWithPolicyWithRoute(invalidDump, options.FlushPolicy, route)
 	if err != nil {
-		fmt.Println("Glide example failed with an error: ", err)
-		return
+		fmt.Println("Error:", err.Error())
 	}
 
-	fmt.Println(result)
-
 	// Output:
-	// OK
+	// Error: An error was signalled by the server: - ResponseError: DUMP payload version or checksum are wrong
 }