PR suggestions

Author: aaron-congo

python/python/glide/async_commands/core.py

@@ -2297,14 +2297,15 @@ async def bzpopmax(
         self, keys: List[str], timeout: float
     ) -> Optional[List[Union[str, float]]]:
         """
-        Blocks the connection until it removes and returns a member with the highest score from the first non-empty
-        sorted set, with the given keys being checked in the order they are provided.
+        Pops the member with the highest score from the first non-empty sorted set, with the given keys being checked in
+        the order that they are given. Blocks the connection when there are no members to remove from any of the given
+        sorted sets.
 
         When in cluster mode, all keys must map to the same hash slot.
 
-        BZPOPMAX is the blocking variant of ZPOPMAX.
+        `BZPOPMAX` is the blocking variant of `ZPOPMAX`.
 
-        BZPOPMAX is a client blocking command, see https://github.com/aws/glide-for-redis/wiki/General-Concepts#blocking-commands for more details and best practices.
+        `BZPOPMAX` is a client blocking command, see https://github.com/aws/glide-for-redis/wiki/General-Concepts#blocking-commands for more details and best practices.
 
         See https://valkey.io/commands/bzpopmax for more details.
 
@@ -2318,8 +2319,10 @@ async def bzpopmax(
                 and the member score. If no member could be popped and the `timeout` expired, returns None.
 
         Examples:
+            >>> await client.zadd("my_sorted_set1", {"member1": 10.0, "member2": 5.0})
+                2  # Two elements have been added to the sorted set at "my_sorted_set1".
             >>> await client.bzpopmax(["my_sorted_set1", "my_sorted_set2"], 0.5)
-                ['my_sorted_set1', 'member1', 10.0]  # 'member1' with a score of 10.0 has been removed from 'my_sorted_set'.
+                ['my_sorted_set1', 'member1', 10.0]  # "member1" with a score of 10.0 has been removed from "my_sorted_set1".
         """
         return cast(
             Optional[List[Union[str, float]]],
@@ -2362,14 +2365,15 @@ async def bzpopmin(
         self, keys: List[str], timeout: float
     ) -> Optional[List[Union[str, float]]]:
         """
-        Blocks the connection until it removes and returns a member with the lowest score from the first non-empty
-        sorted set, with the given keys being checked in the order they are provided.
+        Pops the member with the lowest score from the first non-empty sorted set, with the given keys being checked in
+        the order that they are given. Blocks the connection when there are no members to remove from any of the given
+        sorted sets.
 
         When in cluster mode, all keys must map to the same hash slot.
 
-        BZPOPMIN is the blocking variant of ZPOPMIN.
+        `BZPOPMIN` is the blocking variant of `ZPOPMIN`.
 
-        BZPOPMIN is a client blocking command, see https://github.com/aws/glide-for-redis/wiki/General-Concepts#blocking-commands for more details and best practices.
+        `BZPOPMIN` is a client blocking command, see https://github.com/aws/glide-for-redis/wiki/General-Concepts#blocking-commands for more details and best practices.
 
         See https://valkey.io/commands/bzpopmin for more details.
 
@@ -2383,8 +2387,10 @@ async def bzpopmin(
                 and the member score. If no member could be popped and the `timeout` expired, returns None.
 
         Examples:
+            >>> await client.zadd("my_sorted_set1", {"member1": 10.0, "member2": 5.0})
+                2  # Two elements have been added to the sorted set at "my_sorted_set1".
             >>> await client.bzpopmin(["my_sorted_set1", "my_sorted_set2"], 0.5)
-                ['my_sorted_set1', 'member1', 1.0]  # 'member1' with a score of 1.0 has been removed from 'my_sorted_set'.
+                ['my_sorted_set1', 'member2', 5.0]  # "member2" with a score of 5.0 has been removed from "my_sorted_set1".
         """
         return cast(
             Optional[List[Union[str, float]]],

python/python/glide/async_commands/transaction.py

@@ -1628,12 +1628,13 @@ def zpopmax(
 
     def bzpopmax(self: TTransaction, keys: List[str], timeout: float) -> TTransaction:
         """
-        Blocks the connection until it removes and returns a member with the highest score from the first non-empty
-        sorted set, with the given keys being checked in the order they are provided.
+        Pops the member with the highest score from the first non-empty sorted set, with the given keys being checked in
+        the order that they are given. Blocks the connection when there are no members to remove from any of the given
+        sorted sets.
 
-        BZPOPMAX is the blocking variant of ZPOPMAX.
+        `BZPOPMAX` is the blocking variant of `ZPOPMAX`.
 
-        BZPOPMAX is a client blocking command, see https://github.com/aws/glide-for-redis/wiki/General-Concepts#blocking-commands for more details and best practices.
+        `BZPOPMAX` is a client blocking command, see https://github.com/aws/glide-for-redis/wiki/General-Concepts#blocking-commands for more details and best practices.
 
         See https://valkey.io/commands/bzpopmax for more details.
 
@@ -1673,12 +1674,13 @@ def zpopmin(
 
     def bzpopmin(self: TTransaction, keys: List[str], timeout: float) -> TTransaction:
         """
-        Blocks the connection until it removes and returns a member with the lowest score from the first non-empty
-        sorted set, with the given keys being checked in the order they are provided.
+        Pops the member with the lowest score from the first non-empty sorted set, with the given keys being checked in
+        the order that they are given. Blocks the connection when there are no members to remove from any of the given
+        sorted sets.
 
-        BZPOPMIN is the blocking variant of ZPOPMIN.
+        `BZPOPMIN` is the blocking variant of `ZPOPMIN`.
 
-        BZPOPMIN is a client blocking command, see https://github.com/aws/glide-for-redis/wiki/General-Concepts#blocking-commands for more details and best practices.
+        `BZPOPMIN` is a client blocking command, see https://github.com/aws/glide-for-redis/wiki/General-Concepts#blocking-commands for more details and best practices.
 
         See https://valkey.io/commands/bzpopmin for more details.
 

python/python/tests/test_async_client.py

@@ -1904,6 +1904,10 @@ async def test_bzpopmin(self, redis_client: TRedisClient):
         ]
         assert await redis_client.bzpopmin(["non_existing_key"], 0.5) is None
 
+        # invalid argument - key list must not be empty
+        with pytest.raises(RequestError):
+            await redis_client.bzpopmin([], 0.5)
+
         # key exists, but it is not a sorted set
         assert await redis_client.set("foo", "value") == OK
         with pytest.raises(RequestError):
@@ -1955,6 +1959,10 @@ async def test_bzpopmax(self, redis_client: TRedisClient):
         ]
         assert await redis_client.bzpopmax(["non_existing_key"], 0.5) is None
 
+        # invalid argument - key list must not be empty
+        with pytest.raises(RequestError):
+            await redis_client.bzpopmax([], 0.5)
+
         # key exists, but it is not a sorted set
         assert await redis_client.set("foo", "value") == OK
         with pytest.raises(RequestError):