Core: Release the read lock while creating connections in refresh_connections#2630
Merged
barshaul merged 1 commit intovalkey-io:release-1.2from Nov 12, 2024
Merged
Conversation
barshaul
force-pushed
the
dont_lock_on_reconnect
branch
2 times, most recently
from
59386d8 to
cb1f91a
Compare
eifrah-aws
approved these changes
Nov 7, 2024
…ections Signed-off-by: barshaul <barshaul@amazon.com>
barshaul
force-pushed
the
dont_lock_on_reconnect
branch
from
c9b3a5b to
256f6d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lock Management Improvement:
In the previous implementation, the read lock (inner.conn_lock.read()) was held throughout the entire connection refresh process (for all connections sent to refresh), including while attempting to establish connections (via get_or_create_conn). If connections were slow or timed out, the lock was held for an extended duration, blocking other tasks requiring a write lock.
The new implementation releases the read lock before making connection attempts. If the connection is successfully established, the read lock is reacquired to update the connection container. This approach ensures that other operations needing the lock (e.g., write operations) can proceed while connections are being established.
This commit was already approved on our redis-rs fork but wasn't merged into glide, see former PR amazon-contributing/redis-rs#191.