Skip to content

Commit 8f71da5

Browse files
author
Release Manager
committed
sagemathgh-40001: Remove giac as dependency, and add sagemath_giac as optional dependency <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Not sure if this change is completely right. It seems to me that there is still a giac expect interface in use, so perhaps giac should now be a runtime dependency instead of build dependency of sagelib? Or is that interface obsolete and should/can be removed? ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40001 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
2 parents 96cf8eb + 67b184f commit 8f71da5

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pyproject.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ requires-python = ">=3.11, <3.14"
7575
R = [
7676
'rpy2 >=3.3',
7777
]
78+
giac = [
79+
'sagemath_giac',
80+
]
7881

7982
[project.readme]
8083
file = "README.md"
@@ -120,7 +123,6 @@ host-requires = [
120123
"pkg:generic/libgd",
121124
"pkg:generic/gap",
122125
"pkg:generic/gfan",
123-
"pkg:generic/giac",
124126
"pkg:generic/givaro",
125127
"pkg:generic/glpk",
126128
"pkg:generic/gmp",

0 commit comments

Comments
 (0)