fix typecheck

Author: fswair

examples/langchain/deepagents_graph.py

@@ -1,9 +1,10 @@
 from __future__ import annotations as _annotations
 
 import os
+from collections.abc import Callable, Sequence
 from importlib.util import find_spec
 from pathlib import Path
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, Any, TypeAlias, cast
 
 from acp.schema import ModelInfo, SessionMode
 from codex_auth_helper import create_codex_chat_openai
@@ -19,6 +20,9 @@
 
 if TYPE_CHECKING:
     from langchain_acp import CompiledAgentGraph
+    from langchain_core.tools import BaseTool
+
+DeepAgentTool: TypeAlias = "BaseTool | Callable[..., Any] | dict[str, Any]"
 
 __all__ = (
     "AVAILABLE_MODELS",
@@ -167,7 +171,9 @@ def _session_workspace_root(session: AcpSessionContext) -> Path:
     return session.cwd.resolve() / _SESSION_ROOT_NAME
 
 
-def _bind_workspace_tools(root: Path) -> tuple[object, object, object]:
+def _bind_workspace_tools(
+    root: Path,
+) -> tuple[Callable[[], str], Callable[[str], str], Callable[[str, str], str]]:
     del root
 
     def _list_workspace_files() -> str:
@@ -206,15 +212,16 @@ def graph_from_session(session: AcpSessionContext) -> CompiledAgentGraph:
     mode_id = session.session_mode_id or DEFAULT_MODE_ID or "ask"
     from deepagents import create_deep_agent
 
+    tools: Sequence[DeepAgentTool] = [
+        *_bind_workspace_tools(workspace_root),
+        *cast(Sequence[DeepAgentTool], native_plan_tools()),
+    ]
     return create_deep_agent(
         model=create_codex_chat_openai(
             model_name,
             instructions=codex_instructions(mode_id=mode_id),
         ),
-        tools=[
-            *_bind_workspace_tools(workspace_root),
-            *native_plan_tools(),
-        ],  # type: ignore[arg-type]
+        tools=tools,
         interrupt_on={"write_file": True},
         name=f"deepagents-{mode_id}-{session.cwd.name}",
     )

packages/helpers/codex-auth-helper/src/codex_auth_helper/factory.py

@@ -90,18 +90,21 @@ def create_codex_chat_openai(
             "`model_kwargs['instructions']`, not both."
         )
     chat_model_kwargs["instructions"] = instructions
+    chat_openai_kwargs: dict[str, Any] = {
+        "model": model_name,
+        "async_client": async_root_client.chat.completions,
+        "client": sync_root_client.chat.completions,
+        "include_response_headers": include_response_headers,
+        "model_kwargs": chat_model_kwargs,
+        "output_version": output_version,
+        "reasoning": reasoning,
+        "root_async_client": async_root_client,
+        "root_client": sync_root_client,
+        "store": False,
+        "temperature": temperature,
+        "use_previous_response_id": use_previous_response_id,
+        "use_responses_api": True,
+    }
     return ChatOpenAI(
-        model_name=model_name,
-        async_client=async_root_client.chat.completions,
-        client=sync_root_client.chat.completions,
-        include_response_headers=include_response_headers,
-        model_kwargs=chat_model_kwargs,
-        output_version=output_version,
-        reasoning=reasoning,
-        root_async_client=async_root_client,
-        root_client=sync_root_client,
-        store=False,
-        temperature=temperature,
-        use_previous_response_id=use_previous_response_id,
-        use_responses_api=True,
+        **chat_openai_kwargs,
     )

tests/pydantic/test_models.py

@@ -1,7 +1,7 @@
 from __future__ import annotations as _annotations
 
 import asyncio
-from typing import Any, cast
+from typing import Any, Protocol, cast
 
 import pytest
 from acp.exceptions import RequestError
@@ -42,6 +42,10 @@
 )
 
 
+class _AdapterWithConfig(Protocol):
+    _config: Any
+
+
 def _passthrough_tools(
     ctx: RunContext[None],
     tool_defs: list[ToolDefinition],
@@ -460,7 +464,8 @@ def route_plan_progress(
     adapter.on_connect(client)
 
     session = asyncio.run(adapter.new_session(cwd=str(tmp_path), mcp_servers=[]))
-    stored_session = cast(Any, adapter)._config.session_store.get(session.session_id)
+    adapter_config = cast(_AdapterWithConfig, adapter)._config
+    stored_session = adapter_config.session_store.get(session.session_id)
     assert stored_session is not None
     stored_session.plan_markdown = "# Plan\n\n1. Implement the first item\n2. Verify it\n"
     stored_session.plan_entries = [
@@ -475,7 +480,7 @@ def route_plan_progress(
             status="pending",
         ).model_dump(mode="json"),
     ]
-    cast(Any, adapter)._config.session_store.save(stored_session)
+    adapter_config.session_store.save(stored_session)
     client.updates.clear()
 
     asyncio.run(