fix coverage

fswair · fswair · commit dc2d520819f1 · 2026-05-08T23:51:55.000+03:00
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-0.9.5
+0.9.6
diff --git a/packages/adapters/langchain-acp/VERSION b/packages/adapters/langchain-acp/VERSION
@@ -1 +1 @@
-0.9.5
+0.9.6
diff --git a/packages/adapters/langchain-acp/src/langchain_acp/_version.py b/packages/adapters/langchain-acp/src/langchain_acp/_version.py
@@ -2,4 +2,4 @@
 
 __all__ = ("__version__",)
 
-__version__ = "0.9.5"
+__version__ = "0.9.6"
diff --git a/packages/adapters/pydantic-acp/VERSION b/packages/adapters/pydantic-acp/VERSION
@@ -1 +1 @@
-0.9.5
+0.9.6
diff --git a/packages/adapters/pydantic-acp/src/pydantic_acp/_version.py b/packages/adapters/pydantic-acp/src/pydantic_acp/_version.py
@@ -2,4 +2,4 @@
 
 __all__ = ("__version__",)
 
-__version__ = "0.9.5"
+__version__ = "0.9.6"
diff --git a/packages/helpers/codex-auth-helper/VERSION b/packages/helpers/codex-auth-helper/VERSION
@@ -1 +1 @@
-0.9.5
+0.9.6
diff --git a/packages/helpers/codex-auth-helper/src/codex_auth_helper/_version.py b/packages/helpers/codex-auth-helper/src/codex_auth_helper/_version.py
@@ -2,4 +2,4 @@
 
 __all__ = ("__version__",)
 
-__version__ = "0.9.5"
+__version__ = "0.9.6"
diff --git a/packages/transports/acpremote/VERSION b/packages/transports/acpremote/VERSION
@@ -1 +1 @@
-0.9.5
+0.9.6
diff --git a/packages/transports/acpremote/src/acpremote/_version.py b/packages/transports/acpremote/src/acpremote/_version.py
@@ -2,4 +2,4 @@
 
 __all__ = ("__version__",)
 
-__version__ = "0.9.5"
+__version__ = "0.9.6"
diff --git a/src/acpkit/_version.py b/src/acpkit/_version.py
@@ -2,4 +2,4 @@
 
 __all__ = ("__version__",)
 
-__version__ = "0.9.5"
+__version__ = "0.9.6"
diff --git a/tests/acpremote/test_helpers.py b/tests/acpremote/test_helpers.py
@@ -191,6 +191,32 @@ async def readline(self) -> bytes:
         return self.lines.pop(0)
 
 
+@dataclass(slots=True)
+class _FakeCommandProcess:
+    stdin: Any = field(default_factory=_FakeStdin)
+    stdout: Any = field(default_factory=object)
+    returncode: int | None = None
+    terminate_calls: int = 0
+    kill_calls: int = 0
+    wait_delay: float = 0.0
+    wait_error: Exception | None = None
+
+    def terminate(self) -> None:
+        self.terminate_calls += 1
+
+    def kill(self) -> None:
+        self.kill_calls += 1
+        self.returncode = -9
+
+    async def wait(self) -> int:
+        await asyncio.sleep(self.wait_delay)
+        if self.wait_error is not None:
+            raise self.wait_error
+        if self.returncode is None:  # pragma: no branch
+            self.returncode = 0
+        return self.returncode
+
+
 @dataclass(slots=True)
 class _FakeCommandWebSocket:
     messages: list[str | bytes]
@@ -515,31 +541,6 @@ async def fake_close_stdin(stdin: Any) -> None:
     monkeypatch.setattr(command_module, "_close_websocket", fake_close_websocket)
     monkeypatch.setattr(command_module, "_close_stdin", fake_close_stdin)
 
-    @dataclass(slots=True)
-    class _FakeProcess:
-        stdin: Any = field(default_factory=object)
-        stdout: Any = field(default_factory=object)
-        returncode: int | None = None
-        terminate_calls: int = 0
-        kill_calls: int = 0
-        wait_delay: float = 0.0
-        wait_error: Exception | None = None
-
-        def terminate(self) -> None:
-            self.terminate_calls += 1
-
-        def kill(self) -> None:
-            self.kill_calls += 1
-            self.returncode = -9
-
-        async def wait(self) -> int:
-            await asyncio.sleep(self.wait_delay)
-            if self.wait_error is not None:
-                raise self.wait_error
-            if self.returncode is None:  # pragma: no branch
-                self.returncode = 0
-            return self.returncode
-
     async def done_immediately(*args: Any, **kwargs: Any) -> None:
         del args, kwargs
         return None
@@ -548,9 +549,9 @@ async def done_later(*args: Any, **kwargs: Any) -> None:
         del args, kwargs
         await asyncio.sleep(0.01)
 
-    fast_exit = _FakeProcess(wait_delay=0.0)
+    fast_exit = _FakeCommandProcess(wait_delay=0.0)
 
-    async def create_fast_process(**kwargs: Any) -> _FakeProcess:
+    async def create_fast_process(**kwargs: Any) -> _FakeCommandProcess:
         del kwargs
         return fast_exit
 
@@ -565,9 +566,9 @@ async def create_fast_process(**kwargs: Any) -> _FakeProcess:
 
     close_calls.clear()
     stdin_close_calls.clear()
-    delayed_exit = _FakeProcess(wait_delay=0.01, wait_error=ProcessLookupError())
+    delayed_exit = _FakeCommandProcess(wait_delay=0.01, wait_error=ProcessLookupError())
 
-    async def create_delayed_process(**kwargs: Any) -> _FakeProcess:
+    async def create_delayed_process(**kwargs: Any) -> _FakeCommandProcess:
         del kwargs
         return delayed_exit
 
@@ -582,50 +583,6 @@ async def create_delayed_process(**kwargs: Any) -> _FakeProcess:
     assert close_calls
     assert stdin_close_calls
 
-    close_calls.clear()
-    stdin_close_calls.clear()
-    timeout_exit = _FakeProcess(wait_delay=0.02)
-
-    async def create_timeout_process(**kwargs: Any) -> _FakeProcess:
-        del kwargs
-        return timeout_exit
-
-    monkeypatch.setattr(command_module, "_create_command_process", create_timeout_process)
-    monkeypatch.setattr(command_module, "_relay_websocket_to_stdin", done_immediately)
-    monkeypatch.setattr(command_module, "_relay_stdout_to_websocket", done_later)
-    await command_module.run_remote_command_connection(
-        cast(Any, object()),
-        command_options=command_module.CommandOptions(
-            command=("echo", "hi"),
-            terminate_timeout=0.001,
-        ),
-    )
-    assert timeout_exit.terminate_calls >= 1
-    assert timeout_exit.kill_calls >= 1
-    assert close_calls
-    assert stdin_close_calls
-
-    close_calls.clear()
-    stdin_close_calls.clear()
-
-    async def all_done(*args: Any, **kwargs: Any) -> None:
-        del args, kwargs
-        return None
-
-    instant_exit = _FakeProcess(wait_delay=0.0)
-
-    async def create_instant_process(**kwargs: Any) -> _FakeProcess:
-        del kwargs
-        return instant_exit
-
-    monkeypatch.setattr(command_module, "_create_command_process", create_instant_process)
-    monkeypatch.setattr(command_module, "_relay_websocket_to_stdin", all_done)
-    monkeypatch.setattr(command_module, "_relay_stdout_to_websocket", all_done)
-    await command_module.run_remote_command_connection(
-        cast(Any, object()),
-        command_options=command_module.CommandOptions(command=("echo", "hi")),
-    )
-
     async def failing_relay(*args: Any, **kwargs: Any) -> None:
         del args, kwargs
         raise ValueError("boom")
@@ -634,9 +591,9 @@ async def slow_relay(*args: Any, **kwargs: Any) -> None:
         del args, kwargs
         await asyncio.sleep(0.05)
 
-    hanging_exit = _FakeProcess(wait_delay=0.05)
+    hanging_exit = _FakeCommandProcess(wait_delay=0.05)
 
-    async def create_hanging_process(**kwargs: Any) -> _FakeProcess:
+    async def create_hanging_process(**kwargs: Any) -> _FakeCommandProcess:
         del kwargs
         return hanging_exit
 
@@ -657,6 +614,43 @@ async def create_hanging_process(**kwargs: Any) -> _FakeProcess:
         command_module.CommandOptions(command=("echo",), terminate_timeout=0)
 
 
+@pytest.mark.asyncio
+async def test_command_process_terminate_timeout_kills() -> None:
+    process = _FakeCommandProcess(wait_delay=0.02)
+
+    await command_module._terminate_process(cast(Any, process), timeout=0.001)
+
+    assert process.terminate_calls == 1
+    assert process.kill_calls == 1
+    assert process.returncode == -9
+
+
+@pytest.mark.asyncio
+async def test_command_connection_covers_all_done_path(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    async def all_done(*args: Any, **kwargs: Any) -> None:
+        del args, kwargs
+        return None
+
+    process = _FakeCommandProcess(wait_delay=0.0)
+
+    async def create_process(**kwargs: Any) -> _FakeCommandProcess:
+        del kwargs
+        return process
+
+    monkeypatch.setattr(command_module, "_create_command_process", create_process)
+    monkeypatch.setattr(command_module, "_relay_websocket_to_stdin", all_done)
+    monkeypatch.setattr(command_module, "_relay_stdout_to_websocket", all_done)
+
+    await command_module.run_remote_command_connection(
+        cast(Any, _FakeCommandWebSocket(messages=[])),
+        command_options=command_module.CommandOptions(command=("echo", "hi")),
+    )
+
+    assert process.returncode == 0
+
+
 @pytest.mark.asyncio
 async def test_proxy_agent_helper_paths_cover_delegate_and_metadata_edges(
     monkeypatch: pytest.MonkeyPatch,

Original file line number	Diff line number	Diff line change
`@@ -2,4 +2,4 @@`
`2`	`2`
`3`	`3`	`__all__ = ("__version__",)`
`4`	`4`
`5`		`-__version__ = "0.9.5"`
	`5`	`+__version__ = "0.9.6"`