Skip to content

Commit 4d78689

Browse files
committed
Stop hardcoding require('next/dist/compiled/react')`
This will be picked up by our `next` alias in `createWebpackAliases`. Any subsequent alias of `next/*` would be ignored e.g. aliasing `next/dist/compiled/react` to the react-server entrypoint. I also hope we don't actually need this since we're already aliasing `react` to `next/dist/compiled/react` in Webpack. At the same time we're not hardcoding `next/dist/compiled/react-dom`. This split in behavior is really confusing. The alternate would be ensuring that our `next` alias becomes a falback. Or list all the public entrypoints. Or remove it entirely.
1 parent 3050f45 commit 4d78689

File tree

74 files changed

+81
-107
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

74 files changed

+81
-107
lines changed

packages/next/src/compiled/react-dom-experimental/cjs/react-dom-server-legacy.browser.development.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ if (process.env.NODE_ENV !== "production") {
1414
(function() {
1515
'use strict';
1616

17-
var React = require("next/dist/compiled/react-experimental");
17+
var React = require('react');
1818
var ReactDOM = require('react-dom');
1919

2020
var ReactVersion = '18.3.0-experimental-c3048aab4-20240326';

packages/next/src/compiled/react-dom-experimental/cjs/react-dom-server-legacy.browser.production.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
'use strict';
1212

13-
var React = require("next/dist/compiled/react-experimental");
13+
var React = require('react');
1414
var ReactDOM = require('react-dom');
1515

1616
// Do not require this module directly! Use normal `invariant` calls with

packages/next/src/compiled/react-dom-experimental/cjs/react-dom-server-legacy.browser.production.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/next/src/compiled/react-dom-experimental/cjs/react-dom-server-legacy.node.development.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ if (process.env.NODE_ENV !== "production") {
1414
(function() {
1515
'use strict';
1616

17-
var React = require("next/dist/compiled/react-experimental");
17+
var React = require('react');
1818
var ReactDOM = require('react-dom');
1919
var stream = require('stream');
2020

packages/next/src/compiled/react-dom-experimental/cjs/react-dom-server-legacy.node.production.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
'use strict';
1212

13-
var React = require("next/dist/compiled/react-experimental");
13+
var React = require('react');
1414
var ReactDOM = require('react-dom');
1515
var stream = require('stream');
1616

packages/next/src/compiled/react-dom-experimental/cjs/react-dom-server-legacy.node.production.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/next/src/compiled/react-dom-experimental/cjs/react-dom-server-rendering-stub.development.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ if (process.env.NODE_ENV !== "production") {
1414
(function() {
1515
'use strict';
1616

17-
var React = require("next/dist/compiled/react-experimental");
17+
var React = require('react');
1818

1919
var ReactSharedInternals = React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED;
2020

packages/next/src/compiled/react-dom-experimental/cjs/react-dom-server-rendering-stub.production.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
'use strict';
1212

13-
var React = require("next/dist/compiled/react-experimental");
13+
var React = require('react');
1414

1515
var ReactVersion = '18.3.0-experimental-c3048aab4-20240326';
1616

packages/next/src/compiled/react-dom-experimental/cjs/react-dom-server-rendering-stub.production.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/next/src/compiled/react-dom-experimental/cjs/react-dom-server.browser.development.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ if (process.env.NODE_ENV !== "production") {
1414
(function() {
1515
'use strict';
1616

17-
var React = require("next/dist/compiled/react-experimental");
17+
var React = require('react');
1818
var ReactDOM = require('react-dom');
1919

2020
var ReactVersion = '18.3.0-experimental-c3048aab4-20240326';

0 commit comments

Comments
 (0)