Skip to content

Commit 7616f52

Browse files
committed
rename .req and .res for node http interfaces
1 parent 7ee6e3f commit 7616f52

File tree

4 files changed

+24
-18
lines changed

4 files changed

+24
-18
lines changed

packages/next/build/webpack/loaders/next-serverless-loader/api-handler.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ export function getApiHandler(ctx: ServerlessHandlerCtx) {
5050
}
5151

5252
await apiResolver(
53-
req.req,
54-
res.res,
53+
req.originalRequest,
54+
res.originalResponse,
5555
Object.assign({}, parsedUrl.query, params),
5656
await pageModule,
5757
encodedPreviewProps,

packages/next/server/base-http.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export class NodeNextRequest extends BaseNextRequest<Readable> {
3737

3838
[NEXT_REQUEST_META]: RequestMeta
3939

40-
get req() {
40+
get originalRequest() {
4141
// Need to mimic these changes to the original req object for places where we use it:
4242
// render.tsx, api/ssg requests
4343
this._req[NEXT_REQUEST_META] = this[NEXT_REQUEST_META]
@@ -138,7 +138,7 @@ export class NodeNextResponse extends BaseNextResponse<Writable> {
138138

139139
public [SYMBOL_CLEARED_COOKIES]?: boolean
140140

141-
get res() {
141+
get originalResponse() {
142142
if (SYMBOL_CLEARED_COOKIES in this) {
143143
this._res[SYMBOL_CLEARED_COOKIES] = this[SYMBOL_CLEARED_COOKIES]
144144
}

packages/next/server/dev/next-dev-server.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -485,7 +485,7 @@ export default class DevServer extends Server {
485485
private setupWebSocketHandler(server?: HTTPServer, _req?: NodeNextRequest) {
486486
if (!this.addedUpgradeListener) {
487487
this.addedUpgradeListener = true
488-
server = server || (_req?.req.socket as any)?.server
488+
server = server || (_req?.originalRequest.socket as any)?.server
489489

490490
if (!server) {
491491
// this is very unlikely to happen but show an error in case
@@ -578,8 +578,8 @@ export default class DevServer extends Server {
578578
}
579579

580580
const { finished = false } = await this.hotReloader!.run(
581-
req.req,
582-
res.res,
581+
req.originalRequest,
582+
res.originalResponse,
583583
parsedUrl
584584
)
585585

packages/next/server/next-server.ts

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -221,8 +221,8 @@ export default class NextNodeServer extends BaseServer {
221221
}
222222
): Promise<void> {
223223
return sendRenderResult({
224-
req: req.req,
225-
res: res.res,
224+
req: req.originalRequest,
225+
res: res.originalResponse,
226226
...options,
227227
})
228228
}
@@ -232,15 +232,15 @@ export default class NextNodeServer extends BaseServer {
232232
res: NodeNextResponse,
233233
path: string
234234
): Promise<void> {
235-
return serveStatic(req.req, res.res, path)
235+
return serveStatic(req.originalRequest, res.originalResponse, path)
236236
}
237237

238238
protected handleCompression(
239239
req: NodeNextRequest,
240240
res: NodeNextResponse
241241
): void {
242242
if (this.compression) {
243-
this.compression(req.req, res.res, () => {})
243+
this.compression(req.originalRequest, res.originalResponse, () => {})
244244
}
245245
}
246246

@@ -279,7 +279,7 @@ export default class NextNodeServer extends BaseServer {
279279
proxyReject(err)
280280
}
281281
})
282-
proxy.web(req.req, res.res)
282+
proxy.web(req.originalRequest, res.originalResponse)
283283
})
284284

285285
return {
@@ -310,8 +310,8 @@ export default class NextNodeServer extends BaseServer {
310310
}
311311

312312
await apiResolver(
313-
req.req,
314-
res.res,
313+
req.originalRequest,
314+
res.originalResponse,
315315
query,
316316
pageModule,
317317
this.renderOpts.previewProps,
@@ -329,11 +329,17 @@ export default class NextNodeServer extends BaseServer {
329329
query: NextParsedUrlQuery,
330330
renderOpts: RenderOpts
331331
): Promise<RenderResult | null> {
332-
return renderToHTML(req.req, res.res, pathname, query, renderOpts)
332+
return renderToHTML(
333+
req.originalRequest,
334+
res.originalResponse,
335+
pathname,
336+
query,
337+
renderOpts
338+
)
333339
}
334340

335341
protected streamResponseChunk(res: NodeNextResponse, chunk: any) {
336-
res.res.write(chunk)
342+
res.originalResponse.write(chunk)
337343
}
338344

339345
protected async imageOptimizer(
@@ -345,8 +351,8 @@ export default class NextNodeServer extends BaseServer {
345351
require('./image-optimizer') as typeof import('./image-optimizer')
346352

347353
return imageOptimizer(
348-
req.req,
349-
res.res,
354+
req.originalRequest,
355+
res.originalResponse,
350356
parsedUrl,
351357
this.nextConfig,
352358
this.distDir,

0 commit comments

Comments
 (0)