Skip to content

Commit 9c025e1

Browse files
hiro0218ijjk
andauthored
Fix typos in test descriptions in router-rerender integration tests (#65834)
This PR fixes minor typos in the test descriptions within the `router-rerender` integration tests. - Fixed "unneccesary" to "unnecessary" in the middleware test description. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by: JJ Kasper <[email protected]>
1 parent f6a2424 commit 9c025e1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/integration/router-rerender/test/index.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ let app
1717

1818
const runTests = () => {
1919
describe('with middleware', () => {
20-
it('should not trigger unncessary rerenders when middleware is used', async () => {
20+
it('should not trigger unnecessary rerenders when middleware is used', async () => {
2121
const browser = await webdriver(appPort, '/')
2222
await new Promise((resolve) => setTimeout(resolve, 100))
2323

@@ -27,7 +27,7 @@ const runTests = () => {
2727

2828
describe('with rewrites', () => {
2929
// TODO: Figure out the `isReady` issue.
30-
it.skip('should not trigger unncessary rerenders when rewrites are used', async () => {})
30+
it.skip('should not trigger unnecessary rerenders when rewrites are used', async () => {})
3131
it.skip('should rerender with the correct query parameter if present with rewrites', async () => {})
3232
})
3333
}

0 commit comments

Comments
 (0)