Skip to content

Commit 21df39f

Browse files
authored
[next] Image Optimization for default loader (#5321)
We currently pass through `images` whenever its defined, but this is enabling Image Optimization in the Proxy for every Next.js project. Instead, we should check to see if the default loader is used (the same use for `next dev`) as a signal to enable this feature in the deployment. Related to vercel/next.js#18122
1 parent 5ad9d61 commit 21df39f

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

packages/now-next/src/index.ts

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -655,12 +655,13 @@ export const build = async ({
655655

656656
return {
657657
output,
658-
images: imagesManifest?.images
659-
? {
660-
domains: imagesManifest.images.domains,
661-
sizes: imagesManifest.images.sizes,
662-
}
663-
: undefined,
658+
images:
659+
imagesManifest?.images?.loader === 'default'
660+
? {
661+
domains: imagesManifest.images.domains,
662+
sizes: imagesManifest.images.sizes,
663+
}
664+
: undefined,
664665
routes: [
665666
// User headers
666667
...headers,
@@ -1952,12 +1953,13 @@ export const build = async ({
19521953
};
19531954
})
19541955
: undefined,
1955-
images: imagesManifest?.images
1956-
? {
1957-
domains: imagesManifest.images.domains,
1958-
sizes: imagesManifest.images.sizes,
1959-
}
1960-
: undefined,
1956+
images:
1957+
imagesManifest?.images?.loader === 'default'
1958+
? {
1959+
domains: imagesManifest.images.domains,
1960+
sizes: imagesManifest.images.sizes,
1961+
}
1962+
: undefined,
19611963
/*
19621964
Desired routes order
19631965
- Runtime headers

packages/now-next/src/utils.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -511,9 +511,12 @@ export async function getDynamicRoutes(
511511
return routes;
512512
}
513513

514+
type LoaderKey = 'imgix' | 'cloudinary' | 'akamai' | 'default';
515+
514516
type ImagesManifest = {
515517
version: number;
516518
images: {
519+
loader: LoaderKey;
517520
sizes: number[];
518521
domains: string[];
519522
};

0 commit comments

Comments
 (0)