feat: remove the build step and load the loader from source #200
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
styfle
changed the title
| main: './main.js', | ||
| chunk: './chunk.js', | ||
| bcrypt: './packages/bcrypt.js', | ||
| bcrypt5: './packages/bcrypt5.js', |
There was a problem hiding this comment.
Should this change be a separate PR or is there a reason we need it for this PR?
There was a problem hiding this comment.
node-pre-gyp was updated. While unit tests were already in place, I added an integration test to provide additional confidence as the foundation was laid in the previous PR. bcrypt v5 is the version that uses node-pre-gyp. And since bcrypt v5 was added, I have also included bcrypt v6.
There was a problem hiding this comment.
Usually I would say this should be a separate PR to prove it was passing before and then the PR to change to mapbox would prove its still passing but I think its fine to leave as is
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
I replaced node-pre-gyp with the latest version, shrinking the dependency graph from 95 to 56 packages. Since both the regular and coverage test modes now load the loader from source, output discrepancies between them have been eliminated. Additionally, I've added integration tests for both node-pre-gyp and node-gyp-build, using bcrypt versions 5 and 6. The split chunk logic in the test project has also been updated so that each entry point now generates its own vendor chunk.
Closes #194