Skip to content

Commit 12cd5c8

Browse files
committed
refactor the code for better extensibility
1 parent e06495b commit 12cd5c8

File tree

12 files changed

+912
-612
lines changed

12 files changed

+912
-612
lines changed
Lines changed: 8 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,6 @@
1-
# # Tests layout
2-
3-
# Each folder under tests/ corresponds to a test category for a sub-namespace in verl. For instance:
4-
# - `tests/trainer` for testing functionality related to `verl/trainer`
5-
# - `tests/models` for testing functionality related to `verl/models`
6-
# - ...
7-
8-
# There are a few folders with `special_` prefix, created for special purposes:
9-
# - `special_distributed`: unit tests that must run with multiple GPUs
10-
# - `special_e2e`: end-to-end tests with training/generation scripts
11-
# - `special_npu`: tests for NPUs
12-
# - `special_sanity`: a suite of quick sanity tests
13-
# - `special_standalone`: a set of test that are designed to run in dedicated environments
14-
15-
# Accelerators for tests
16-
# - By default tests are run with GPU available, except for the ones under `special_npu`, and any test script whose name ends with `on_cpu.py`.
17-
# - For test scripts with `on_cpu.py` name suffix would be tested on CPU resources in linux environment.
18-
19-
# # Workflow layout
20-
21-
# All CI tests are configured by yaml files in `.github/workflows/`. Here's an overview of all test configs:
22-
# 1. A list of always triggered CPU sanity tests: `check-pr-title.yml`, `secrets_scan.yml`, `check-pr-title,yml`, `pre-commit.yml`, `doc.yml`
23-
# 2. Some heavy multi-GPU unit tests, such as `model.yml`, `vllm.yml`, `sgl.yml`
24-
# 3. End-to-end tests: `e2e_*.yml`
25-
# 4. Unit tests
26-
# - `cpu_unit_tests.yml`, run pytest on all scripts with file name pattern `tests/**/test_*_on_cpu.py`
27-
# - `gpu_unit_tests.yml`, run pytest on all scripts with file without the `on_cpu.py` suffix.
28-
# - Since cpu/gpu unit tests by default runs all tests under `tests`, please make sure tests are manually excluded in them when
29-
# - new workflow yaml is added to `.github/workflows`
30-
# - new tests are added to workflow mentioned in 2.
31-
# name: Check PR Title
32-
331
name: cluster_analyse
342

353
on:
36-
# Trigger the workflow on push or pull request,
37-
# but only for the main branch
384
push:
395
branches:
406
- main
@@ -48,30 +14,33 @@ on:
4814
- .github/workflows/cluster_analyse.yml
4915
- "tests/tools/cluster_analyse/**"
5016

51-
# Cancel jobs on the same ref if a new one is triggered
5217
concurrency:
5318
group: ${{ github.workflow }}-${{ github.ref }}
5419
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
5520

56-
# Declare permissions just read content.
5721
permissions:
5822
contents: read
5923

6024
jobs:
6125
cluster_analyse:
6226
runs-on: ubuntu-latest
63-
timeout-minutes: 5 # Increase this timeout value as needed
27+
timeout-minutes: 5
6428
strategy:
6529
matrix:
6630
python-version: ["3.11"]
6731
steps:
32+
- name: Checkout code
33+
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
34+
6835
- name: Set up Python ${{ matrix.python-version }}
6936
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
7037
with:
7138
python-version: ${{ matrix.python-version }}
72-
- name: Install the current repository
39+
40+
- name: Install dependencies
7341
run: |
7442
pip3 install pandas plotly json
75-
- name: Run cluster_analyse test
43+
44+
- name: Run cluster_analyse tests
7645
run: |
7746
pytest -s -x tests/tools/cluster_analyse

tests/tools/cluster_analyse/test_data_preprocessor.py

Lines changed: 0 additions & 34 deletions
This file was deleted.

tests/tools/cluster_analyse/test_parser.py

Lines changed: 0 additions & 102 deletions
This file was deleted.

tests/tools/cluster_analyse/test_rl_timeline_visualize.py

Lines changed: 0 additions & 41 deletions
This file was deleted.

0 commit comments

Comments
 (0)